Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757919AbbLBLkh (ORCPT ); Wed, 2 Dec 2015 06:40:37 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48304 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757191AbbLBLkf (ORCPT ); Wed, 2 Dec 2015 06:40:35 -0500 X-Sasl-enc: kWcaTkl/VrZyfhLfuiqwtbnuMaz8Z8jb2d1bk+yCr1Y3 1449056434 From: Hannes Frederic Sowa To: Stefan Priebe - Profihost AG , Florian Weimer Cc: Thomas Gleixner , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au Subject: Re: Asterisk deadlocks since Kernel 4.1 In-Reply-To: <565EBDC1.1090808@profihost.ag> References: <564B3D35.50004@profihost.ag> <564B7F9D.5060701@profihost.ag> <564CDE2F.8000201@profihost.ag> <564CEB0C.40006@redhat.com> <564CEF5D.3080005@profihost.ag> <564D9A17.6080305@redhat.com> <564D9B21.302@profihost.ag> <564D9CE6.2090104@profihost.ag> <1447933294.1974772.444210441.67F1AC5E@webmail.messagingengine.com> <564DB5F5.9060208@profihost.ag> <1447936902.1986892.444251921.3928A049@webmail.messagingengine.com> <564DC4A5.70104@profihost.ag> <564DCC4C.1090009@redhat.com> <564E2852.8000200@profihost.ag> <56530A42.6030609@profihost.ag> <1448283451.4019628.447573353.3659E447@webmail.messagingengine.com> <565EBDC1.1090808@profihost.ag> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-redhat-linux-gnu) Date: Wed, 02 Dec 2015 12:40:32 +0100 Message-ID: <8737vlt6xb.fsf@stressinduktion.org> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 45 Hello Stefan, Stefan Priebe - Profihost AG writes: > here are the results. > > It works with 4.1. > It works with 4.2. > It does not work with 4.1.13. > > git bisect tells me it stopped working after those two commits were applied: > > commit d48623677191e0f035d7afd344f92cf880b01f8e > Author: Herbert Xu > Date: Tue Sep 22 11:38:56 2015 +0800 > > netlink: Replace rhash_portid with bound > > commit 4e27762417669cb459971635be550eb7b5598286 > Author: Herbert Xu > Date: Fri Sep 18 19:16:50 2015 +0800 > > netlink: Fix autobind race condition that leads to zero port ID Cool, thanks a lot. Does this patch make a difference? diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 59651af..278e94c 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1137,7 +1137,7 @@ static int netlink_insert(struct sock *sk, u32 portid) /* We need to ensure that the socket is hashed and visible. */ smp_wmb(); - nlk_sk(sk)->bound = portid; + nlk_sk(sk)->bound = true; err: release_sock(sk); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/