Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758101AbbLBNB7 (ORCPT ); Wed, 2 Dec 2015 08:01:59 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:33787 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756465AbbLBNB5 (ORCPT ); Wed, 2 Dec 2015 08:01:57 -0500 Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak To: Borislav Petkov References: <564F051E.9010703@profitbricks.com> <20151125150806.GG2064@8bytes.org> <5655D072.1000901@profitbricks.com> <565EC9F4.2050401@profitbricks.com> <565ECE54.5080706@profitbricks.com> <565ED81B.3020606@profitbricks.com> <20151202115142.GD18805@8bytes.org> <565EE4AA.4070309@profitbricks.com> <20151202125315.GB3910@pd.tnic> Cc: Joerg Roedel , Catalin Marinas , iommu@lists.linux-foundation.org, Linux Kernel Mailing List From: Michael Wang Message-ID: <565EEBC3.5050807@profitbricks.com> Date: Wed, 2 Dec 2015 14:01:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151202125315.GB3910@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 32 On 12/02/2015 01:53 PM, Borislav Petkov wrote: > On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote: >> It's not my work or your work... it's a defect in the module and maintainer >> should take responsibility on fixing it, correct? > > Well, you said "actually we just want to get rid of this annoying report > on obj won't leak..." > > It sounds to me like you want to have something fixed. So you do the > patch properly, add to the commit message why exactly you're doing it > and test it. Like everyone else. Yeah.. it's a little complicated since we have our own kernel tree and this won't be a problem for us, but we really prefer to help fix it in mainline too, as long as this is really a defect, so others could save time on research in future. But seems like we can only wait for another chance to confirm the another solution, frankly speaking I think we both will forgot this soon... fortunately it's not that critical :-P Regards, Michael Wang > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/