Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758131AbbLBNH4 (ORCPT ); Wed, 2 Dec 2015 08:07:56 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34287 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757447AbbLBNHz (ORCPT ); Wed, 2 Dec 2015 08:07:55 -0500 Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak To: Joerg Roedel References: <564F051E.9010703@profitbricks.com> <20151125150806.GG2064@8bytes.org> <5655D072.1000901@profitbricks.com> <565EC9F4.2050401@profitbricks.com> <565ECE54.5080706@profitbricks.com> <565ED81B.3020606@profitbricks.com> <20151202115142.GD18805@8bytes.org> <565EE4AA.4070309@profitbricks.com> <20151202125636.GE18805@8bytes.org> Cc: Catalin Marinas , iommu@lists.linux-foundation.org, Linux Kernel Mailing List From: Michael Wang Message-ID: <565EED28.7050308@profitbricks.com> Date: Wed, 2 Dec 2015 14:07:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151202125636.GE18805@8bytes.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 37 On 12/02/2015 01:56 PM, Joerg Roedel wrote: > On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote: >> It's not my work or your work... it's a defect in the module and maintainer >> should take responsibility on fixing it, correct? > > No, its a false positive from an in-kernel checking tool, the iommu > driver is correct. You just sent a patch to silence the false positive > report. Yeah, but caused by the driver :-P and have to be fixed in there too. > >> We're very willing to help, but as I mentioned we are out of resource for >> testing at this moment, but we can send you a new patch without testing, >> will that works for you? > > This should be testable on any AMD IOMMU system with working interrupt > remapping. I will probably have no time to test this, if you really > can't test yourself, try to get a Tested-by from someone else. Good point, anyone willing to help test the fix? Or better provide the new patch to be the author. Regards, Michael Wang > > > > Joerg > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/