Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758118AbbLBNMh (ORCPT ); Wed, 2 Dec 2015 08:12:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757426AbbLBNMg (ORCPT ); Wed, 2 Dec 2015 08:12:36 -0500 Subject: Re: [PATCH] sched/core: Clear the root_domain cpumasks in init_rootdomain() To: Peter Zijlstra References: <1449057179-29321-1-git-send-email-xlpang@redhat.com> <20151202123414.GB9928@worktop.ger.corp.intel.com> Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Steven Rostedt From: Xunlei Pang Message-ID: <565EEE3E.30301@redhat.com> Date: Wed, 2 Dec 2015 21:12:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151202123414.GB9928@worktop.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 23 Hi Peter, On 12/02/2015 at 08:34 PM, Peter Zijlstra wrote: > On Wed, Dec 02, 2015 at 07:52:59PM +0800, Xunlei Pang wrote: >> The patch cleans the garbage by using zalloc_cpumask_var() >> instead of alloc_cpumask_var() for root_domain::rto_mask >> allocation, thereby addressing the issues. > How did you notice this? Also do we want to do the same for the kmalloc When doing review. > in alloc_rootdomain() ? There is a "memset(rd, 0, sizeof(*rd))" in init_rootdomain(), so I don't think we need to do this in alloc_rootdomain(). Regards, Xunlei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/