Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758661AbbLBOrF (ORCPT ); Wed, 2 Dec 2015 09:47:05 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:42282 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757371AbbLBOrD (ORCPT ); Wed, 2 Dec 2015 09:47:03 -0500 From: Felipe Balbi To: Heikki Krogerus CC: Chanwoo Choi , Greg Kroah-Hartman , MyungJoo Ham , David Cohen , Lu Baolu , Mathias Nyman , , Subject: Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC In-Reply-To: <20151202091324.GA7587@kuha.fi.intel.com> References: <1448976758-35807-1-git-send-email-heikki.krogerus@linux.intel.com> <1448976758-35807-3-git-send-email-heikki.krogerus@linux.intel.com> <87oae9zyy9.fsf@saruman.tx.rr.com> <20151202091324.GA7587@kuha.fi.intel.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 2 Dec 2015 08:46:53 -0600 Message-ID: <8737vksyaq.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1992 Lines: 54 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Heikki Krogerus writes: > Hi Felipe, > >> IMHO, this should be creating a child device instead of calling >> intel_usb_mux_register() directly. That way, your mux driver could >> actually _be_ a driver. Seems like all you need to do from this point is >> a register a simple platform_device which is a child of xhci, see >> platform_device_register_simple() for how to do this. >>=20 >> Or rather, platform_device_register_rsndata() passing xhci's device >> pointer as parent. > > That was the plan originally, but unfortunately it does not work in > this case. It creates conflict as platform_device_add() call will then > claim part of io memory belonging to xHCI, making xHCI fail to probe. okay, understood. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWXwReAAoJEIaOsuA1yqREBIYQAJISSq0+64REVjH4pjA2shZZ tB3jgaMOK+q6SQ9ti5LjXNKEn0ECwGA4DJkJYTdGt1WRCBPnUnK753L2cRDgrSrR 4cXP5E9RglrLopvgGJlrsptvo+1xn+RCLc0I7vNfEbllyB4LMV/si69jQeEOH+VK c1nWknC2aDb6Wjl0gbGPbqFw13DLe9Zi+ncoHT3EhzDRnMn3eDiVdKcRN2phSSRI XXxkh9/GemtEu3rSG/N8e9nizQ2bcWivSItG0kHOCmKa1bpC6OWoZOlXTh9VA1wJ hMI0HtJJKCDOmw3H5sK9evK+P8yc4nMFBpRXPAm4CKcvO5YSBIijWAy+M4I9LDXq UFkw4fXJzCEuDEjy4bA1TC76bPEsjLyj/RCkQK08X6i4Ips+u8NziG2anMSh1ErK 0ek/uUcYAb7fYsLbLxAxri51Un/3oxeIjGED3FD+ckpSI5gzjg2R9L7nMJcXjPTi /bjO8q0oSY+rHuqYVBCjl4a7cHtLFNgddEo0i7dz8ujXdUDQ+xL/9VszS808nJa1 lGQSYMbunOPwVgLCtRWu29qtef/HrcZPHI0e19Hy8yA/0fZhDzZ66ti9UUrnDO/y BhqBJmH1fmFtzYXSWidPS/+zaDUbJXHI7tqL6p//ZHeRsxoFOj9mjmh+fUS03itc k9Rvg2PlnJXjm8ueQ3wn =HWSY -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/