Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932324AbbLBPDJ (ORCPT ); Wed, 2 Dec 2015 10:03:09 -0500 Received: from hauke-m.de ([5.39.93.123]:60856 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755110AbbLBPDG (ORCPT ); Wed, 2 Dec 2015 10:03:06 -0500 Subject: Re: [PATCH v4 5/5] ARM: BCM: Add SMP support for Broadcom 4708 To: Kapil Hali , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ray Jui , Scott Branden , Jon Mason , Florian Fainelli References: <1448987049-17041-1-git-send-email-kapilh@broadcom.com> <1448987049-17041-6-git-send-email-kapilh@broadcom.com> Cc: Gregory Fong , Lee Jones , Kever Yang , Maxime Ripard , Olof Johansson , Paul Walmsley , Linus Walleij , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com From: Hauke Mehrtens Message-ID: <565F0827.4000406@hauke-m.de> Date: Wed, 2 Dec 2015 16:03:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448987049-17041-6-git-send-email-kapilh@broadcom.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3007 Lines: 90 On 12/01/2015 05:24 PM, Kapil Hali wrote: > From: Jon Mason > > Add SMP support for Broadcom's 4708 SoCs. > > Signed-off-by: Jon Mason > Acked-by: Hauke Mehrtens > Tested-by: Hauke Mehrtens > Signed-off-by: Kapil Hali > --- > arch/arm/boot/dts/bcm4708.dtsi | 2 ++ > arch/arm/mach-bcm/Kconfig | 1 + > arch/arm/mach-bcm/Makefile | 3 +++ > 3 files changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm4708.dtsi b/arch/arm/boot/dts/bcm4708.dtsi > index 31141e8..eed4dd1 100644 > --- a/arch/arm/boot/dts/bcm4708.dtsi > +++ b/arch/arm/boot/dts/bcm4708.dtsi > @@ -15,6 +15,7 @@ > cpus { > #address-cells = <1>; > #size-cells = <0>; > + enable-method = "brcm,bcm-nsp-smp"; > > cpu@0 { > device_type = "cpu"; > @@ -27,6 +28,7 @@ > device_type = "cpu"; > compatible = "arm,cortex-a9"; > next-level-cache = <&L2>; > + secondary-boot-reg = <0xffff0400>; > reg = <0x1>; > }; > }; > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 83765a0..e85246f 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -54,6 +54,7 @@ config ARCH_BCM_NSP > config ARCH_BCM_5301X > bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 > select ARCH_BCM_IPROC > + select HAVE_SMP > help > Support for Broadcom BCM470X and BCM5301X SoCs with ARM CPU cores. > When applying this patch please make sure it is correctly applied this patch causes some problems here: http://www.spinics.net/lists/arm-kernel/msg462137.html > diff --git a/arch/arm/mach-bcm/Makefile b/arch/arm/mach-bcm/Makefile > index 5193a25..7d66515 100644 > --- a/arch/arm/mach-bcm/Makefile > +++ b/arch/arm/mach-bcm/Makefile > @@ -43,6 +43,9 @@ obj-$(CONFIG_ARCH_BCM2835) += board_bcm2835.o > > # BCM5301X > obj-$(CONFIG_ARCH_BCM_5301X) += bcm_5301x.o > +ifeq ($(CONFIG_ARCH_BCM_5301X),y) > +obj-$(CONFIG_SMP) += platsmp.o > +endif > > # BCM63XXx > ifeq ($(CONFIG_ARCH_BCM_63XX),y) > I am getting this on a Northstar 1 / BCM4708: [ 0.137634] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 [ 0.143643] Setting up static identity map for 0x82a0 - 0x82d4 [ 0.189772] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001 [ 0.189861] Brought up 2 CPUs [ 0.198845] SMP: Total of 2 processors activated (3188.32 BogoMIPS). [ 0.205446] CPU: WARNING: CPU(s) started in wrong/inconsistent modes (primary CPU mode 0x13) [ 0.214167] CPU: This may indicate a broken bootloader or firmware. I assume that this is correct and the bootloader is just broken, it uses this bootloader: "CFE for Foxconn Router version: v1.0.14", I haven't noticed any problems, so it is ok for me. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/