Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S268802AbTCCU4I>; Mon, 3 Mar 2003 15:56:08 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S268803AbTCCU4I>; Mon, 3 Mar 2003 15:56:08 -0500
Received: from pixpat.austin.ibm.com ([192.35.232.241]:50163 "EHLO
	baldur.austin.ibm.com") by vger.kernel.org with ESMTP
	id <S268802AbTCCU4H>; Mon, 3 Mar 2003 15:56:07 -0500
Date: Mon, 03 Mar 2003 15:06:21 -0600
From: Dave McCracken <dmccr@us.ibm.com>
To: Andrew Morton <akpm@digeo.com>
cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 2.5.63] Teach page_mapped about the anon flag
Message-ID: <103400000.1046725581@baldur.austin.ibm.com>
In-Reply-To: <20030227142450.1c6a6b72.akpm@digeo.com>
References: <20030227025900.1205425a.akpm@digeo.com>
 <200302280822.09409.kernel@kolivas.org>
 <20030227134403.776bf2e3.akpm@digeo.com>
 <118810000.1046383273@baldur.austin.ibm.com>
 <20030227142450.1c6a6b72.akpm@digeo.com>
X-Mailer: Mulberry/2.2.1 (Linux/x86)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="==========1907709384=========="
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2555
Lines: 70

--==========1907709384==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--On Thursday, February 27, 2003 14:24:50 -0800 Andrew Morton
<akpm@digeo.com> wrote:

> I'm just looking at page_mapped().  It is now implicitly assuming that the
> architecture's representation of a zero-count atomic_t is all-bits-zero.
> 
> This is not true on sparc32 if some other CPU is in the middle of an
> atomic_foo() against that counter.  Maybe the assumption is false on other
> architectures too.
> 
> So page_mapped() really should be performing an atomic_read() if that is
> appropriate to the particular page.  I guess this involves testing
> page->mapping.  Which is stable only when the page is locked or
> mapping->page_lock is held.
> 
> It appears that all page_mapped() callers are inside lock_page() at
> present, so a quick audit and addition of a comment would be appropriate
> there please.

I'm not at all confident that page_mapped() is adequately protected.
Here's a patch that explicitly handles the atomic_t case.

Dave McCracken

======================================================================
Dave McCracken          IBM Linux Base Kernel Team      1-512-838-3059
dmccr@us.ibm.com                                        T/L   678-3059

--==========1907709384==========
Content-Type: text/plain; charset=iso-8859-1; name="objfix-2.5.63-1.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment; filename="objfix-2.5.63-1.diff"; size=718

--- 2.5.63-objrmap/include/linux/mm.h	2003-02-27 15:58:34.000000000 -0600
+++ 2.5.63-objfix/include/linux/mm.h	2003-02-28 14:21:56.000000000 -0600
@@ -363,10 +363,16 @@
  * Return true if this page is mapped into pagetables.  Subtle: test =
pte.direct
  * rather than pte.chain.  Because sometimes pte.direct is 64-bit, and =
.chain
  * is only 32-bit.
+ *
+ * If the page is an object-mapped page, we need to do an atomic read of
+ * pte.mapcount instead, since atomic values may not be zero in the upper =
bits.
  */
 static inline int page_mapped(struct page *page)
 {
-	return page->pte.direct !=3D 0;
+	if (PageAnon(page))
+		return page->pte.direct !=3D 0;
+	else
+		return atomic_read(&page->pte.mapcount) !=3D 0;
 }
=20
 /*

--==========1907709384==========--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/