Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932879AbbLBQ7o (ORCPT ); Wed, 2 Dec 2015 11:59:44 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36730 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbbLBQ7n (ORCPT ); Wed, 2 Dec 2015 11:59:43 -0500 Message-ID: <1449075580.6379.1.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH 3/6] net: thunderx: Increase transmit queue length From: Eric Dumazet To: Sunil Kovvuri Cc: David Miller , Pavel Fedin , Linux Netdev List , LKML , LAKML , Sunil Goutham , Sunil Goutham Date: Wed, 02 Dec 2015 08:59:40 -0800 In-Reply-To: References: <01d101d12c46$2de43b40$89acb1c0$@samsung.com> <1448983985.25582.35.camel@edumazet-glaptop2.roam.corp.google.com> <20151201.143047.82022857078130793.davem@davemloft.net> <1449062733.32764.53.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 20 On Wed, 2015-12-02 at 22:20 +0530, Sunil Kovvuri wrote: > > > > If the performance increase is 4 %, then surely using twice more memory > > is not worth it. > I haven't mentioned anywhere that i am seeing 4% increase in performance. Yes, this is the complain I made : No numbers, just a patch increasing ring size by a 100% factor ! I really hope you'll have very convincing numbers, especially if your driver does not implement BQL. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/