Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933404AbbLBRDr (ORCPT ); Wed, 2 Dec 2015 12:03:47 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:58964 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759092AbbLBRD3 (ORCPT ); Wed, 2 Dec 2015 12:03:29 -0500 Message-ID: <565F2410.9040607@huawei.com> Date: Wed, 2 Dec 2015 17:02:08 +0000 From: Salil Mehta User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: David Miller CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem References: <1448522050-5576-1-git-send-email-salil.mehta@huawei.com> <1448522050-5576-2-git-send-email-salil.mehta@huawei.com> <20151130.145057.216796732457000987.davem@davemloft.net> In-Reply-To: <20151130.145057.216796732457000987.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.174.67] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.565F242E.00FF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 9c192fc1963e008cfc8b706c9f20a321 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 35 On 11/30/2015 7:50 PM, David Miller wrote: > From: Salil Mehta > Date: Thu, 26 Nov 2015 07:14:06 +0000 > >> -#define ENABLE (0x1) >> -#define DISABLE (0x0) >> +#define ENABLE 0x1 >> +#define DISABLE 0x0 > Defining such common macros names for such incredibly simple boolean values > is asking for trouble, in particular it can possibly collide with other > defines in the global namespace. > > Use "true", "false", and the "bool" type, because that is exactly how you > are using these values. > > Thanks. Hi David, Thanks for your suggestions. I have worked upon the comments and removed these macros and introduced the 'bool' type here as well. I think I missed this in my earlier rework. Thanks again for pointing it out. I have floated new V6 patch for your consideration. Best Regards Salil > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/