Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757447AbbLBSLy (ORCPT ); Wed, 2 Dec 2015 13:11:54 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:58187 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755017AbbLBSLw (ORCPT ); Wed, 2 Dec 2015 13:11:52 -0500 Date: Wed, 2 Dec 2015 11:11:45 -0700 From: Jason Gunthorpe To: "Wilck, Martin" Cc: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Peter Huewe , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Message-ID: <20151202181145.GA30972@obsidianresearch.com> References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 26 On Wed, Dec 02, 2015 at 01:34:38PM +0100, Wilck, Martin wrote: > On Di, 2015-12-01 at 11:58 -0700, Jason Gunthorpe wrote: > > > Martin, this should fix the double loading you noticed, please confirm. There > > is a possibility the force path needs a bit more code to be compatible with > > devm_ioremap_resource, I'm not sure, hoping not. > > Nope, this one oopses in the ACPI probing path. This fixes this oops: chip->vendor.iobase = devm_ioremap_resource(dev, &tpm_info->res); - if (!chip->vendor.iobase) - return -EIO; + if (IS_ERR(chip->vendor.iobase)) + return PTR_ERR(chip->vendor.iobase); And I see that the ACPI stuff needs other work :( Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/