Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933094AbbLBSUU (ORCPT ); Wed, 2 Dec 2015 13:20:20 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54994 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933037AbbLBSUQ (ORCPT ); Wed, 2 Dec 2015 13:20:16 -0500 Date: Wed, 2 Dec 2015 19:20:12 +0100 From: Pavel Machek To: Gang He Cc: mfasheh@suse.com, rgoldwyn@suse.de, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, akpm@linux-foundation.org, Greg KH Subject: Re: [PATCH v2 0/4] Add online file check feature Message-ID: <20151202182012.GA21249@amd> References: <1446013561-22121-1-git-send-email-ghe@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446013561-22121-1-git-send-email-ghe@suse.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 27 On Wed 2015-10-28 14:25:57, Gang He wrote: > When there are errors in the ocfs2 filesystem, > they are usually accompanied by the inode number which caused the error. > This inode number would be the input to fixing the file. > One of these options could be considered: > A file in the sys filesytem which would accept inode numbers. > This could be used to communication back what has to be fixed or is fixed. > You could write: > $# echo "CHECK " > /sys/fs/ocfs2/devname/filecheck > or > $# echo "FIX " > /sys/fs/ocfs2/devname/filecheck > Are you sure this is reasonable interface? I mean.... sysfs is supposed to be one value per file. And I don't think its suitable for running commands. ...or returning back results. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/