Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758996AbbLBTIT (ORCPT ); Wed, 2 Dec 2015 14:08:19 -0500 Received: from mail-qg0-f49.google.com ([209.85.192.49]:34940 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756214AbbLBTIR (ORCPT ); Wed, 2 Dec 2015 14:08:17 -0500 From: "Geyslan G. Bem" To: peter.senna@gmail.com, jg.victorino1@gmail.com, raphaelscarv@gmail.com Cc: "Geyslan G. Bem" , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ia64: bitvector_process could read out of bounds Date: Wed, 2 Dec 2015 16:07:35 -0300 Message-Id: <1449083269-29614-1-git-send-email-geyslan@gmail.com> X-Mailer: git-send-email 2.6.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 35 The units[] array could be accessed out of its bounds due the lack of verification of the max vector value. To make this function not prone to error "P" and "E" suffixes were added. Despite the new suffixes are unrelated to current ia64 vm magnitudes, they make the code ready for it and avoid misleadings. Catched using static analysis (cppcheck). Signed-off-by: Geyslan G. Bem --- arch/ia64/kernel/palinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/kernel/palinfo.c b/arch/ia64/kernel/palinfo.c index c39c3cd..160aba1 100644 --- a/arch/ia64/kernel/palinfo.c +++ b/arch/ia64/kernel/palinfo.c @@ -126,7 +126,7 @@ static const char *mem_attrib[]={ static void bitvector_process(struct seq_file *m, u64 vector) { int i,j; - static const char *units[]={ "", "K", "M", "G", "T" }; + static const char *units[] = { "", "K", "M", "G", "T", "P", "E" }; for (i=0, j=0; i < 64; i++ , j=i/10) { if (vector & 0x1) -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/