Date: Wed, 2 Dec 2015 22:09:18 +0300
From: Mike Krinkin <krinkin.m.u@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, kent.overstreet@gmail.com,
        dmonakhov@openvz.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: add calls to split trace point
Message-ID: <20151202190918.GA4325@kmu-tp-x230>
References: <1447786432-7553-1-git-send-email-krinkin.m.u@gmail.com>
 <20151118140129.GD18820@lst.de>
 <20151202082550.GA23340@kmu-tp-x230>
 <565F2501.40301@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <565F2501.40301@kernel.dk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 992
Lines: 29

On Wed, Dec 02, 2015 at 10:06:09AM -0700, Jens Axboe wrote:
> On 12/02/2015 01:25 AM, Mike Krinkin wrote:
> >Hi Jens,
> >
> >i would like to check status of the patch, will the patch be applied?
> >
> 
> Why aren't you just putting the split trace call into blk_queue_split()?

Do you mean after split? Something like this:

	if (split) {
		/* there isn't chance to merge the splitted bio */
		split->bi_rw |= REQ_NOMERGE;

		bio_chain(split, *bio);
		trace_block_split(q, split, bio->bi_iter.bi_sector);
		generic_make_request(*bio);
		*bio = split;
	}

block_split trace event docs says that it expects "bio being split", i
understood it as "bio before split". But scarcely someone depends on
this behaviour, so i'll resend the patch, is it ok?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/