Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756400AbbLBUNR (ORCPT ); Wed, 2 Dec 2015 15:13:17 -0500 Received: from proxima.lp0.eu ([81.2.80.65]:46117 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbbLBUNO (ORCPT ); Wed, 2 Dec 2015 15:13:14 -0500 Subject: Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding To: Brian Norris References: <56506D55.3000907@simon.arlott.org.uk> <20151122215945.GA5930@rob-hp-laptop> <56523E85.905@simon.arlott.org.uk> <56523EFF.9050502@simon.arlott.org.uk> <56535977.9050201@gmail.com> <56541BD3.4070202@simon.arlott.org.uk> <5654AF69.7040901@gmail.com> <20151202190555.GJ64635@google.com> <565F4953.2070206@simon.arlott.org.uk> <20151202200036.GL64635@google.com> Cc: Florian Fainelli , Rob Herring , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , David Woodhouse , linux-mtd@lists.infradead.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonas Gorski , bcm-kernel-feedback-list@broadcom.com, Kamal Dasu From: Simon Arlott Message-ID: <565F50B0.4020802@simon.arlott.org.uk> Date: Wed, 2 Dec 2015 20:12:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151202200036.GL64635@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1625 Lines: 55 On 02/12/15 20:00, Brian Norris wrote: > Hi, > > On Wed, Dec 02, 2015 at 07:41:07PM +0000, Simon Arlott wrote: >> >> + nand0: nandcs@0 { >> >> + compatible = "brcm,nandcs"; >> >> + >> >> + #address-cells = <0>; >> >> + #size-cells = <0>; > >> I think they're also implicit so you can just remove those two lines. > > From ePAPR: "The #address-cells and #size-cells properties are not > inherited from ancestors in the device tree. They shall be explicitly > defined." > > But we don't want to define them. I'd drop them, at least from the > example, as they're not relevant. Ok. >> I've created a bcm963268part driver so there won't need to be any >> partitions in DT for bcm63268. > > Just curious, do you plan to submit this driver? We're working on Yes, it's just the most recent one I've been working on. I still have USBH and IUDMA to submit > matching up partition parsers to flash devices via device tree > of_match_table's, so you could do something like this: > > nand0: nandcs@0 { > compatible = "brcm,nandcs"; > ... > > partitions { > compatible = "brcm,bcm963268-partitions"; > ... > }; > }; I modified brcmnand to look for a machine matching "brcm,bcm963268", but that way is ok with me. Presumably "ofpart" defers to another matching partition parser? Is there a patch for that method of parser detection available? -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/