Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756801AbbLBVrZ (ORCPT ); Wed, 2 Dec 2015 16:47:25 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55804 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbbLBVrX (ORCPT ); Wed, 2 Dec 2015 16:47:23 -0500 Message-ID: <565F66E7.20207@collabora.co.uk> Date: Wed, 02 Dec 2015 21:47:19 +0000 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Rob Herring CC: Olof Johansson , "linux-kernel@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" Subject: Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware References: <1448997171-7064-1-git-send-email-martyn.welch@collabora.co.uk> <1448997171-7064-2-git-send-email-martyn.welch@collabora.co.uk> <20151202151552.GA11101@rob-hp-laptop> <565F2137.609@collabora.co.uk> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2167 Lines: 67 On 02/12/15 18:44, Rob Herring wrote: > On Wed, Dec 2, 2015 at 10:49 AM, Martyn Welch > wrote: >> >> >> On 02/12/15 15:15, Rob Herring wrote: >>> >>> On Tue, Dec 01, 2015 at 07:12:49PM +0000, Martyn Welch wrote: >>>> >>>> This patch adds documentation for the chromeos-firmware binding. >>>> >>>> Cc: Rob Herring >>>> Cc: Pawel Moll >>>> Cc: Mark Rutland >>>> Cc: Ian Campbell >>>> Cc: Kumar Gala >>>> Cc: devicetree@vger.kernel.org >>>> Signed-off-by: Martyn Welch >>>> --- >>>> .../devicetree/bindings/misc/chromeos-firmware.txt | 27 >>>> ++++++++++++++++++++++ >>> >>> >>> bindings/firmware/ please. >>> >> >> OK. >> >>>> 1 file changed, 27 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/misc/chromeos-firmware.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/misc/chromeos-firmware.txt >>>> b/Documentation/devicetree/bindings/misc/chromeos-firmware.txt >>>> new file mode 100644 >>>> index 0000000..8240611 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/misc/chromeos-firmware.txt >>>> @@ -0,0 +1,27 @@ >>>> +Device-Tree bindings for chromeos-firmware.c. >>> >>> >>> Perhaps a bit more description what this is. >>> >>> What aspect of this is firmware? How does this relate to the EC? >>> >> >> With respect to write-protect, this line is the write protection for the >> flash which holds the bootloader. > > What is driving the write-protect? Are trying to assign ownership of > the SOC GPIOs to the bootloader/firmware? If so, I think this is all > wrong. > The lines are typically driven by a debugging board plugged into a socket on the Chromebooks motherboard, not by the device it's self. The driver exposes a read-only interface to these signals. Martyn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/