Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756807AbbLBWJF (ORCPT ); Wed, 2 Dec 2015 17:09:05 -0500 Received: from mail-vk0-f50.google.com ([209.85.213.50]:33475 "EHLO mail-vk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754437AbbLBWJD (ORCPT ); Wed, 2 Dec 2015 17:09:03 -0500 MIME-Version: 1.0 In-Reply-To: <20151202215851.GC31125@kroah.com> References: <1449093046-22039-1-git-send-email-geyslan@gmail.com> <20151202215851.GC31125@kroah.com> Date: Wed, 2 Dec 2015 19:09:02 -0300 Message-ID: Subject: Re: [PATCH] usb: ehci: ohci: use true/false for bool From: "Geyslan G. Bem" To: Greg Kroah-Hartman Cc: Peter Senna Tschudin , Alan Stern , Sergei Shtylyov , Johannes Weiner , Michal Hocko , Andrew Morton , Masanari Iida , "Rafael J. Wysocki" , Saurabh Karajgaonkar , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 42 2015-12-02 18:58 GMT-03:00 Greg Kroah-Hartman : > On Wed, Dec 02, 2015 at 06:50:41PM -0300, Geyslan G. Bem wrote: >> When bool use true or false instead of 1 or 0. >> >> Caught by coccinelle. >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/ehci-hcd.c | 2 +- >> drivers/usb/host/ohci-hcd.c | 4 ++-- >> drivers/usb/host/u132-hcd.c | 2 +- >> 3 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c >> index 48c92bf..1b01967 100644 >> --- a/drivers/usb/host/ehci-hcd.c >> +++ b/drivers/usb/host/ehci-hcd.c >> @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO); >> MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); >> >> /* for flakey hardware, ignore overcurrent indicators */ >> -static bool ignore_oc = 0; >> +static bool ignore_oc = false; > > No need to set this to "0/false" as that's what the default is. > > thanks, > > greg k-h Thanks Greg, sending v2. -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/