Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932253AbbLBXIe (ORCPT ); Wed, 2 Dec 2015 18:08:34 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35111 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758193AbbLBXHf (ORCPT ); Wed, 2 Dec 2015 18:07:35 -0500 Date: Wed, 2 Dec 2015 15:07:32 -0800 From: Brian Norris To: Han Xu Cc: Michal Suchanek , Heiner Kallweit , David Woodhouse , Mark Brown , Boris Brezillon , Javier Martinez Canillas , Rafal Milecki , Jagan Teki , "Andrew F. Davis" , Mika Westerberg , Gabor Juhos , Bean Huo , Furquan Shaikh , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v6 03/10] mtd: fsl-quadspi: return amount of data read/written or error Message-ID: <20151202230732.GT64635@google.com> References: <20151202210626.GA21512@chopperman.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151202210626.GA21512@chopperman.am.freescale.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 37 On Wed, Dec 02, 2015 at 03:06:28PM -0600, Han Xu wrote: > On Wed, Dec 02, 2015 at 10:38:19AM +0000, Michal Suchanek wrote: > > Return amount of data read/written or error as read(2)/write(2) does. > > > > Signed-off-by: Michal Suchanek > > --- > > drivers/mtd/spi-nor/fsl-quadspi.c | 18 +++++++++++------- > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c > > index 10d2b59..9beb739 100644 > > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > > @@ -575,7 +575,7 @@ static inline void fsl_qspi_invalid(struct fsl_qspi *q) > > writel(reg, q->iobase + QUADSPI_MCR); > > } > > > > -static int fsl_qspi_nor_write(struct fsl_qspi *q, struct spi_nor *nor, > > +static ssize_t fsl_qspi_nor_write(struct fsl_qspi *q, struct spi_nor *nor, > > conflict with the patch I acked. > > https://patchwork.ozlabs.org/patch/545925/ > > I may change it and test on my side. I'll let you know if I need things rebased. If conflicts are trivial, I can handle it. But right now, the linked patch (big endian support) is incomplete (no documentation), and Michal's was just sent today. So it remains to be seen which will be "ready" first. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/