Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758694AbbLBX2d (ORCPT ); Wed, 2 Dec 2015 18:28:33 -0500 Received: from mail-vk0-f53.google.com ([209.85.213.53]:35125 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757400AbbLBX2a (ORCPT ); Wed, 2 Dec 2015 18:28:30 -0500 MIME-Version: 1.0 In-Reply-To: References: <1449094171-30346-1-git-send-email-geyslan@gmail.com> <20151202221650.GB24544@kroah.com> Date: Wed, 2 Dec 2015 20:28:29 -0300 Message-ID: Subject: Re: [PATCH v2] usb: ehci: ohci: use true/false for bool From: "Geyslan G. Bem" To: Greg Kroah-Hartman Cc: Peter Senna Tschudin , Alan Stern , Sergei Shtylyov , Johannes Weiner , Andrew Morton , Mel Gorman , "Rafael J. Wysocki" , Masanari Iida , Saurabh Karajgaonkar , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1819 Lines: 63 2015-12-02 19:23 GMT-03:00 Geyslan G. Bem : > 2015-12-02 19:16 GMT-03:00 Greg Kroah-Hartman : >> On Wed, Dec 02, 2015 at 07:09:19PM -0300, Geyslan G. Bem wrote: >>> When declaring/initializing bool use true instead of 1. If it's false, >>> there's no need to explicit initialize it, once it's default. >>> >>> Caught by coccinelle. >>> >>> Signed-off-by: Geyslan G. Bem >>> --- >>> drivers/usb/host/ehci-hcd.c | 2 +- >>> drivers/usb/host/ohci-hcd.c | 4 ++-- >>> drivers/usb/host/u132-hcd.c | 2 +- >>> 3 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c >>> index 48c92bf..1b01967 100644 >>> --- a/drivers/usb/host/ehci-hcd.c >>> +++ b/drivers/usb/host/ehci-hcd.c >>> @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO); >>> MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); >>> >>> /* for flakey hardware, ignore overcurrent indicators */ >>> -static bool ignore_oc = 0; >>> +static bool ignore_oc; >> >> This should be a separate patch as it's doing something differently than >> what you describe. >> >> thanks, >> >> greg k-h > > Greg, > > I think that the v2 description is ok, the title is misleading indeed. > I'll make a new one entitled "fix bool initialization". Anything else? Please ignore my last statements. Report to this: [PATCH] usb: ehci: ohci: fix bool assignments > > Thanks. > > -- > Regards, > > Geyslan G. Bem > hackingbits.com -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/