Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757232AbbLCAtK (ORCPT ); Wed, 2 Dec 2015 19:49:10 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:34704 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754717AbbLCAtH (ORCPT ); Wed, 2 Dec 2015 19:49:07 -0500 Date: Wed, 2 Dec 2015 16:49:03 -0800 From: Brian Norris To: Caesar Wang Cc: Heiko Stuebner , Eduardo Valentin , lkp@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Zhang Rui , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures Message-ID: <20151203004903.GA9543@google.com> References: <1447044542-30859-1-git-send-email-wxt@rock-chips.com> <1447044542-30859-7-git-send-email-wxt@rock-chips.com> <20151202183851.GA91131@google.com> <565F8FFE.3080807@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565F8FFE.3080807@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 34 Hi Caesar, On Thu, Dec 03, 2015 at 08:42:38AM +0800, Caesar Wang wrote: > ? 2015?12?03? 02:38, Brian Norris ??: > > [.....] > > if (thermal->tshut_temp > INT_MAX) { > > CID 1341498: Integer handling issues (CONSTANT_EXPRESSION_RESULT) > > "thermal->tshut_temp > 2147483647 /* (int)(~0U >> 1) */" is always false regardless of the values of its operands. This occurs as the logical operand of if. > > > >I don't think this condition is even useful any more, so maybe we should > >just kill the 'if' block. > > See the patch to fix > it.----->(https://patchwork.kernel.org/patch/7720601/) > - if (thermal->tshut_temp > INT_MAX) { + if (!(thermal->tshut_temp < INT_MAX)) { Huh? That still doesn't make much sense. The condition is still impossible, since thermal->tshut_temp is an int. You've just made it slightly harder for static analyzers to notice the impossibility. > This patch is merged into kernel 4.4-rc3. No it isn't, and I'm glad. The patch is silly. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/