Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758640AbbLCEsT (ORCPT ); Wed, 2 Dec 2015 23:48:19 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:35524 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758380AbbLCEsS convert rfc822-to-8bit (ORCPT ); Wed, 2 Dec 2015 23:48:18 -0500 MIME-Version: 1.0 In-Reply-To: <20151124162924.GK807@x1> References: <1447665197-26501-1-git-send-email-saurabh.truth@gmail.com> <20151124162924.GK807@x1> Date: Thu, 3 Dec 2015 10:18:17 +0530 Message-ID: Subject: Re: [PATCH] mfd: mc13xxx-core: use of_property_read_bool() From: Saurabh Sengar To: Lee Jones Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2308 Lines: 60 I couldn't see this patch applied in linux-next branch still. Regards, Saurabh On 24 November 2015 at 21:59, Lee Jones wrote: > On Mon, 16 Nov 2015, Saurabh Sengar wrote: > >> for checking if a property is present or not, >> use of_property_read_bool instead of of_get_property() >> >> Signed-off-by: Saurabh Sengar >> --- >> drivers/mfd/mc13xxx-core.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) > > I'm fine with the change, but in future please use the commit format > expected of the subsystem. In this case, you are missing upper-case > characters at the start of the subject line AND the start of the > commit log. In fact, it is devoid of sufficient punctuation in > general. > > I have applied this and fixed up the issues; this time! > >> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c >> index 3f9f4c8..d7f54e4 100644 >> --- a/drivers/mfd/mc13xxx-core.c >> +++ b/drivers/mfd/mc13xxx-core.c >> @@ -383,16 +383,16 @@ static int mc13xxx_probe_flags_dt(struct mc13xxx *mc13xxx) >> if (!np) >> return -ENODEV; >> >> - if (of_get_property(np, "fsl,mc13xxx-uses-adc", NULL)) >> + if (of_property_read_bool(np, "fsl,mc13xxx-uses-adc")) >> mc13xxx->flags |= MC13XXX_USE_ADC; >> >> - if (of_get_property(np, "fsl,mc13xxx-uses-codec", NULL)) >> + if (of_property_read_bool(np, "fsl,mc13xxx-uses-codec")) >> mc13xxx->flags |= MC13XXX_USE_CODEC; >> >> - if (of_get_property(np, "fsl,mc13xxx-uses-rtc", NULL)) >> + if (of_property_read_bool(np, "fsl,mc13xxx-uses-rtc")) >> mc13xxx->flags |= MC13XXX_USE_RTC; >> >> - if (of_get_property(np, "fsl,mc13xxx-uses-touch", NULL)) >> + if (of_property_read_bool(np, "fsl,mc13xxx-uses-touch")) >> mc13xxx->flags |= MC13XXX_USE_TOUCHSCREEN; >> >> return 0; > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/