Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751561AbbLCFRr (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Dec 2015 00:17:47 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37713 "EHLO
	out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751314AbbLCFRZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Dec 2015 00:17:25 -0500
X-Sasl-enc: UXPlBlNsHyo0azr55W4rl8pf74sOiw/qgStGj60epqmk 1449119843
Date: Wed, 2 Dec 2015 21:17:21 -0800
From: Greg KH <greg@kroah.com>
To: Gang He <ghe@suse.com>
Cc: pavel@ucw.cz, akpm@linux-foundation.org, ocfs2-devel@oss.oracle.com,
        Mark Fasheh <MFasheh@suse.com>, rgoldwyn@suse.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Add online file check feature
Message-ID: <20151203051721.GA5241@kroah.com>
References: <1446013561-22121-1-git-send-email-ghe@suse.com>
 <20151202182012.GA21249@amd>
 <566013E7020000F900020CA2@relay2.provo.novell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <566013E7020000F900020CA2@relay2.provo.novell.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1717
Lines: 39

On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote:
> Hello Pavel,
> 
> 
> 
> >>> 
> > On Wed 2015-10-28 14:25:57, Gang He wrote:
> >> When there are errors in the ocfs2 filesystem,
> >> they are usually accompanied by the inode number which caused the error.
> >> This inode number would be the input to fixing the file.
> >> One of these options could be considered:
> >> A file in the sys filesytem which would accept inode numbers.
> >> This could be used to communication back what has to be fixed or is fixed.
> >> You could write:
> >> $# echo "CHECK <inode>" > /sys/fs/ocfs2/devname/filecheck
> >> or
> >> $# echo "FIX <inode>" > /sys/fs/ocfs2/devname/filecheck
> >> 
> > 
> > Are you sure this is reasonable interface? I mean.... sysfs is
> > supposed to be one value per file. And I don't think its suitable for
> > running commands.
> Usually, the corrupted file (inode) should be rarely encountered for OCFS2 file system, then
> lots of commands are executed via this interface with high performance is not expected by us.
> Second, after online file check is added, we also plan to add a mount option "error=fix", that means
> the file system can fix these errors automatically without a manual command triggering.

It's not a "performance" issue, it's a "sysfs files only have one value"
type thing.  Have two files, "inode_fix" and "inode_check" and then just
write the inode into them, no need to have a "verb <inode>" type parser.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/