Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410AbbLCHL7 (ORCPT ); Thu, 3 Dec 2015 02:11:59 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34332 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932268AbbLCHLv (ORCPT ); Thu, 3 Dec 2015 02:11:51 -0500 From: Joonsoo Kim X-Google-Original-From: Joonsoo Kim To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Rik van Riel , David Rientjes , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim Subject: [PATCH v3 5/7] mm/compaction: respect compaction order when updating defer counter Date: Thu, 3 Dec 2015 16:11:19 +0900 Message-Id: <1449126681-19647-6-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449126681-19647-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1449126681-19647-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 59 It doesn't make sense that we reset defer counter in compaction_defer_reset() when compaction request under the order of compact_order_failed succeed. Fix it. And, it does make sense that giving enough chance for updated failed order compaction before deferring. Change it. Signed-off-by: Joonsoo Kim --- mm/compaction.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 67b8d90..1a75a6e 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -126,11 +126,14 @@ static struct page *pageblock_pfn_to_page(unsigned long start_pfn, */ static void defer_compaction(struct zone *zone, int order) { - zone->compact_considered = 0; - zone->compact_defer_shift++; - - if (order < zone->compact_order_failed) + if (order < zone->compact_order_failed) { + zone->compact_considered = 0; + zone->compact_defer_shift = 0; zone->compact_order_failed = order; + } else { + zone->compact_considered = 0; + zone->compact_defer_shift++; + } if (zone->compact_defer_shift > COMPACT_MAX_DEFER_SHIFT) zone->compact_defer_shift = COMPACT_MAX_DEFER_SHIFT; @@ -161,11 +164,11 @@ bool compaction_deferred(struct zone *zone, int order) /* Update defer tracking counters after successful compaction of given order */ static void compaction_defer_reset(struct zone *zone, int order) { - zone->compact_considered = 0; - zone->compact_defer_shift = 0; - - if (order >= zone->compact_order_failed) + if (order >= zone->compact_order_failed) { + zone->compact_considered = 0; + zone->compact_defer_shift = 0; zone->compact_order_failed = order + 1; + } trace_mm_compaction_defer_reset(zone, order); } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/