Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758973AbbLCIae (ORCPT ); Thu, 3 Dec 2015 03:30:34 -0500 Received: from dgate10.ts.fujitsu.com ([80.70.172.49]:32431 "EHLO dgate10.ts.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679AbbLCIad (ORCPT ); Thu, 3 Dec 2015 03:30:33 -0500 DomainKey-Signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:Received:Received:From:To:CC:Date:Subject: Thread-Topic:Thread-Index:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator:acceptlanguage: Content-Type:Content-Transfer-Encoding:MIME-Version; b=OxKrD992GFlELpY4h6H+R7aCroAqEObsBVzzZr3tnxTma90xi6lJ/dlu QT+BEJ4uS6ZgQF+x/ZHBpWkEAOyDqBU/a29FDNlMfGukuryWso0OkFU1t wnBi+nSyOBubuyiM50CZa0WaJlaHudGXUUW2GLBkPDbirMNLg1ovXZlbj CjNkHbwZd81oBTwWUP8OseVy/ZTSGqj3pyhm6dXU6UFIZ9zd3TuJCcmar jzO9i/H8z/s/RMH+aVXsUc5fC8jXP; X-SBRSScore: None From: "Wilck, Martin" To: Jason Gunthorpe CC: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , =?utf-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= Date: Thu, 3 Dec 2015 09:30:30 +0100 Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Thread-Topic: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Thread-Index: AdEtpN6wj9sPRqC7R4CFn+HtrOkeng== Message-ID: References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151202182726.GB30972@obsidianresearch.com> <20151202191155.GA2832@obsidianresearch.com> In-Reply-To: <20151202191155.GA2832@obsidianresearch.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: de-DE, en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB38UcBQ012325 Content-Length: 983 Lines: 20 On Mi, 2015-12-02 at 12:11 -0700, Jason Gunthorpe wrote: > > What is the address tpm_tis should be using? I see two things, it > > either uses the x86 default address or it expects the ACPI to have a > > MEM resource. AFAIK ACPI should never rely on hard wired addresses, so > > I removed that code in this series. Perhaps tpm_tis should be using > > control_area_pa ? Will ACPI ever present a struct resource? (if yes, > > why isn't tpm_crb using one?) > > Is then still a problem. On Martin's system the MSFT0101 device does > not have a struct resource attached to it. Does any system, or is this > just dead code? ACPI defines a mem resource corresponding to the standard TIS memory area on my system, and it used to be detected fine with Jarkko's patch. Somehow your latest changes broke it, not sure why. Martin ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?