Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932478AbbLCI7y (ORCPT ); Thu, 3 Dec 2015 03:59:54 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:34516 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758865AbbLCI7x (ORCPT ); Thu, 3 Dec 2015 03:59:53 -0500 MIME-Version: 1.0 In-Reply-To: <565FFF5F.3000303@unitn.it> References: <1449056847-17190-1-git-send-email-wanpeng.li@hotmail.com> <20151202120454.GZ20439@e106622-lin> <565EFB6A.10607@unitn.it> <565FFF5F.3000303@unitn.it> Date: Thu, 3 Dec 2015 16:59:51 +0800 Message-ID: Subject: Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic From: Wanpeng Li To: Luca Abeni Cc: Wanpeng Li , Juri Lelli , Ingo Molnar , Peter Zijlstra , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 44 2015-12-03 16:37 GMT+08:00 Luca Abeni : > Hi, > > On 12/03/2015 03:25 AM, Wanpeng Li wrote: > [...] >>> >>> @@ -202,16 +197,18 @@ static void dequeue_pushable_dl_task(struct rq *rq, >>> struct task_struct *p) >>> >>> next_node = rb_next(&p->pushable_dl_tasks); >>> dl_rq->pushable_dl_tasks_leftmost = next_node; >>> + if (next_node) >>> + dl_rq->earliest_dl.next = rb_entry(next_node, >>> + struct task_struct, >>> pushable_dl_tasks)->dl.deadline; >> >> >> Juri mentioned "updated leftmost", I'm not sure if it means that: >> >> @@ -195,6 +195,9 @@ static void dequeue_pushable_dl_task(struct rq >> *rq, struct task_struct *p) >> >> next_node = rb_next(&p->pushable_dl_tasks); >> dl_rq->pushable_dl_tasks_leftmost = next_node; >> + if (dl_rq->pushable_dl_tasks_leftmost) >> + dl_rq->earliest_dl.next = >> rb_entry(dl_rq->pushable_dl_tasks_leftmost, >> + struct task_struct, >> pushable_dl_tasks)->dl.deadline; >> } > > This is basically the same thing I tested (I just used "next_node" instead > of "dl_rq->pushable_dl_tasks_leftmost" because the name is shorter), so I > think it should work. Yeah, the same, what I want to know is Juri's choice. Ping Juri, :-) Regards, Wanpeng Li -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/