Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932815AbbLCJbf (ORCPT ); Thu, 3 Dec 2015 04:31:35 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:36214 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932724AbbLCJba (ORCPT ); Thu, 3 Dec 2015 04:31:30 -0500 From: Rasmus Villemoes To: Felipe Balbi Cc: Greg Kroah-Hartman , , Subject: Re: [PATCH 3/3] usb: musb: remove redundant stack buffer Organization: D03 References: <1448620703-13101-1-git-send-email-linux@rasmusvillemoes.dk> <1448620703-13101-3-git-send-email-linux@rasmusvillemoes.dk> <874mg21ae7.fsf@saruman.tx.rr.com> X-Hashcash: 1:20:151203:linux-kernel@vger.kernel.org::VI/1JQe5Dccwmk8Y:0000000000000000000000000000000000Le/ X-Hashcash: 1:20:151203:balbi@ti.com::5PQ0ONCDE5Rgle2V:000000tqD X-Hashcash: 1:20:151203:gregkh@linuxfoundation.org::T2y2ZmDZr93PAPCs:000000000000000000000000000000000002MOH X-Hashcash: 1:20:151203:linux-usb@vger.kernel.org::ds4sJEZcq9zI+gD7:000000000000000000000000000000000000ED1o Date: Thu, 03 Dec 2015 10:31:26 +0100 In-Reply-To: <874mg21ae7.fsf@saruman.tx.rr.com> (Felipe Balbi's message of "Tue, 1 Dec 2015 09:00:48 -0600") Message-ID: <87vb8fq3o1.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 29 On Tue, Dec 01 2015, Felipe Balbi wrote: > Hi, > > Rasmus Villemoes writes: >> aRevision is only used once, so we might as well do the formatting as >> part of the pr_debug. This eliminates the stack buffer, and avoids >> doing the formatting at all when pr_debug is compiled out. >> >> Signed-off-by: Rasmus Villemoes > > this needs to be rebased on top of my testing/next: git url, please. > checking file drivers/usb/musb/musb_core.c > Hunk #1 FAILED at 1458. > Hunk #2 FAILED at 1506. > 2 out of 2 hunks FAILED Did 1/3 and 2/3 apply? They touch some of the same lines, so clearly 3/3 wouldn't apply by itself. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/