Date: Thu, 3 Dec 2015 10:35:25 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Xunlei Pang <xlpang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] sched/core: Clear the root_domain cpumasks in
 init_rootdomain()
Message-ID: <20151203093525.GQ17308@twins.programming.kicks-ass.net>
References: <1449057179-29321-1-git-send-email-xlpang@redhat.com>
 <20151202123414.GB9928@worktop.ger.corp.intel.com>
 <565EEE3E.30301@redhat.com>
 <20151202162542.GT3816@twins.programming.kicks-ass.net>
 <565FAC78.3030205@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <565FAC78.3030205@redhat.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 909
Lines: 25

On Thu, Dec 03, 2015 at 10:44:08AM +0800, Xunlei Pang wrote:

> > Nice, will you be looking for similar issues elsewhere in the scheduler
> > too?
> 
> Sure :-)

Thanks!

> >>> in alloc_rootdomain() ?
> >> There is a "memset(rd, 0, sizeof(*rd))" in init_rootdomain(),
> >> so I don't think we need to do this in alloc_rootdomain().
> > Ah, right there is. Which also clears the mask for small systems.
> 
> Yeah, maybe we can improve it using alloc_cpumask_var() with
> __GFP_ZERO instead of zalloc_cpumask_var() to avoid duplicate
> clean for small systems.

This isn't a performance critical path, so clarity and correctness are
more important than performance.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/