From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Jiancheng Xue <xuejiancheng@huawei.com>, linux@arm.linux.org.uk,
        khilman@linaro.org, olof@lixom.net, xuwei5@hisilicon.com,
        haojian.zhuang@linaro.org, zhangfei.gao@linaro.org,
        bintian.wang@huawei.com, suwenping@hisilicon.com,
        linux-kernel@vger.kernel.org, yanhaifeng@hisilicon.com,
        gaofei@hisilicon.com, ml.yang@hisilicon.com, yanghongwei@hisilicon.com
Subject: Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc
Date: Thu, 03 Dec 2015 10:40:01 +0100
Message-ID: <8647404.sBOFNLAMdU@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1449110565-23590-1-git-send-email-xuejiancheng@huawei.com>
References: <1449110565-23590-1-git-send-email-xuejiancheng@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1282
Lines: 42

On Thursday 03 December 2015 10:42:45 Jiancheng Xue wrote:
> --- a/arch/arm/mach-hisi/Kconfig
> +++ b/arch/arm/mach-hisi/Kconfig
> @@ -12,6 +12,14 @@ if ARCH_HISI
>  
>  menu "Hisilicon platform type"
>  
> +config ARCH_HI3519
> +       bool "Hisilicon Hi3519 Soc" if ARCH_MULTI_V7
> +       select HAVE_ARM_ARCH_TIMER
> +       select ARCH_HAS_RESET_CONTROLLER
> +
> +       help
> +         Support for Hisilicon Hi3519 Soc
> +
>  config ARCH_HI3xxx
>         bool "Hisilicon Hi36xx family" if ARCH_MULTI_V7
>         select CACHE_L2X0

Do those need to be separate? I would just extend the Hi36xx
to cover all Hi3xxx, if nothing in the platform code really
depends on this.

> +
> +static const char *const hi3519_compat[] __initconst = {
> +       "hisilicon,hi3519",
> +       NULL,
> +};
> +
> +DT_MACHINE_START(HI3519_DT, "Hisilicon Hi3519 (Flattened Device Tree)")
> +       .dt_compat      = hi3519_compat,
> +MACHINE_END

Also drop the "(Flattened Device Tree)" part of the name, we don't
support any other kind anyway.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/