From: Arnd Bergmann <arnd@arndb.de>
To: Jiancheng Xue <xuejiancheng@huawei.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        mturquette@baylibre.com, sboyd@codeaurora.org, xuwei5@hisilicon.com,
        haojian.zhuang@linaro.org, zhangfei.gao@linaro.org,
        bintian.wang@huawei.com, yanhaifeng@hisilicon.com,
        yanghongwei@hisilicon.com, suwenping@hisilicon.com,
        ml.yang@hisilicon.com, gaofei@hisilicon.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file
Date: Thu, 03 Dec 2015 10:44:27 +0100
Message-ID: <1615805.jmP28L2rmX@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1449110364-23464-1-git-send-email-xuejiancheng@huawei.com>
References: <1449110364-23464-1-git-send-email-xuejiancheng@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1995
Lines: 55

On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote:
> +#ifndef __DTS_HI3519_CLOCK_H
> +#define __DTS_HI3519_CLOCK_H

Please try to avoid adding headers like this if you can at all.

I might ask you to merge the header file in one merge window
otherwise and submit the platform code one kernel later, as they
tendn to cause us needless dependencies otherwise.


> +/* fixed rate */
> +#define HI3519_FIXED_400M              1
> +#define HI3519_FIXED_200M              2
> +#define HI3519_FIXED_125M              3
> +#define HI3519_FIXED_150M              4
> +#define HI3519_FIXED_75M               5
> +#define HI3519_FIXED_300M              6
> +#define HI3519_FIXED_50M               7
> +#define HI3519_FIXED_24M               8
> +#define HI3519_FIXED_3M                        9
> +
> +/* mux clocks */
> +#define HI3519_FMC_MUX                 32
> +#define HI3519_I2C_MUX                 33
> +#define HI3519_UART_MUX                        34
> +#define HI3519_SYSAXI_MUX              35
> +
> +/*fixed factor clocks*/
> +#define HI3519_SYSAPB_CLK              64
> +
> +/* gate clocks */
> +#define HI3519_FMC_CLK                 129
> +#define HI3519_UART0_CLK               153
> +#define HI3519_UART1_CLK               154
> +#define HI3519_UART2_CLK               155
> +#define HI3519_UART3_CLK               156
> +#define HI3519_UART4_CLK               157

Where do those numbers come from? They are not consecutive, so it sounds
like they are directly from the data sheet and won't be needed in the driver.
If that's true, just use the numbers directly, as you do for everything
else.

> +#define HI3519_NR_CLKS                 256
> +#define HI3519_NR_RSTS                 256
> 
These seem to not be needed at all.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/