Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964790AbbLCKRd (ORCPT ); Thu, 3 Dec 2015 05:17:33 -0500 Received: from outbound-smtp01.blacknight.com ([81.17.249.7]:48919 "EHLO outbound-smtp01.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759357AbbLCKR2 (ORCPT ); Thu, 3 Dec 2015 05:17:28 -0500 Date: Thu, 3 Dec 2015 10:17:19 +0000 From: Mel Gorman To: "Huang, Ying" Cc: Michal Hocko , lkp@01.org, LKML , Andrew Morton , Rik van Riel , Vitaly Wool , David Rientjes , Christoph Lameter , Johannes Weiner , Vlastimil Babka , Will Deacon , Linus Torvalds Subject: Re: [lkp] [mm, page_alloc] d0164adc89: -100.0% fsmark.app_overhead Message-ID: <20151203101719.GG2015@techsingularity.net> References: <20151126132511.GG14880@techsingularity.net> <87oaegmeer.fsf@yhuang-dev.intel.com> <20151127100647.GH14880@techsingularity.net> <87h9k4kzcv.fsf@yhuang-dev.intel.com> <20151202110009.GA2015@techsingularity.net> <20151202120046.GE25284@dhcp22.suse.cz> <20151202140845.GA19677@suse.de> <20151202141529.GG25284@dhcp22.suse.cz> <20151202144525.GC2015@techsingularity.net> <87k2ovyl4y.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <87k2ovyl4y.fsf@yhuang-dev.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2589 Lines: 60 On Thu, Dec 03, 2015 at 04:46:53PM +0800, Huang, Ying wrote: > Mel Gorman writes: > > > On Wed, Dec 02, 2015 at 03:15:29PM +0100, Michal Hocko wrote: > >> > > I didn't mention this allocation failure because I am not sure it is > >> > > really related. > >> > > > >> > > >> > I'm fairly sure it is. The failure is an allocation site that cannot > >> > sleep but did not specify __GFP_HIGH. > >> > >> yeah but this was the case even before your patch. As the caller used > >> GFP_ATOMIC then it got __GFP_ATOMIC after your patch so it still > >> managed to do ALLOC_HARDER. I would agree if this was an explicit > >> GFP_NOWAIT. Unless I am missing something your patch hasn't changed the > >> behavior for this particular allocation. > >> > > > > You're right. I think it's this hunk that is the problem. > > > > @@ -1186,7 +1186,7 @@ static struct request *blk_mq_map_request(struct > > request_queue *q, > > ctx = blk_mq_get_ctx(q); > > hctx = q->mq_ops->map_queue(q, ctx->cpu); > > blk_mq_set_alloc_data(&alloc_data, q, > > - __GFP_WAIT|GFP_ATOMIC, false, ctx, hctx); > > + __GFP_WAIT|__GFP_HIGH, false, ctx, hctx); > > rq = __blk_mq_alloc_request(&alloc_data, rw); > > ctx = alloc_data.ctx; > > hctx = alloc_data.hctx; > > > > This specific path at this patch is not waking kswapd any more when it > > should. A series of allocations there could hit the watermarks and never wake > > kswapd and then be followed by an atomic allocation failure that woke kswapd. > > > > This bug gets fixed later by the commit 71baba4b92dc ("mm, page_alloc: > > rename __GFP_WAIT to __GFP_RECLAIM") so it's not a bug in the current > > kernel. However, it happens to break bisection and would be caught if each > > individual commit was tested. > > > > Your __GFP_HIGH patch is still fine although not the direct fix for this > > specific problem. Commit 71baba4b92dc is. > > > > Ying, does the page allocation failure messages happen when the whole > > series is applied? i.e. is 4.4-rc3 ok? > > There are allocation errors for 4.4-rc3 too. dmesg is attached. > What is the result of the __GFP_HIGH patch to give it access to reserves? -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/