Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965023AbbLCLlU (ORCPT ); Thu, 3 Dec 2015 06:41:20 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:36705 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbbLCLlR (ORCPT ); Thu, 3 Dec 2015 06:41:17 -0500 Subject: Re: [PATCH v2 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint To: LABBE Corentin References: <1449060889-20447-1-git-send-email-clabbe.montjoie@gmail.com> <1449060889-20447-2-git-send-email-clabbe.montjoie@gmail.com> <565EF9EB.3000509@cogentembedded.com> <20151203075257.GA13787@Red> Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org From: Sergei Shtylyov Message-ID: <56602A5A.4020701@cogentembedded.com> Date: Thu, 3 Dec 2015 14:41:14 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151203075257.GA13787@Red> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1989 Lines: 64 Hello. On 12/3/2015 10:52 AM, LABBE Corentin wrote: >>> The simple_strtol function is obsolete. >>> This patch replace it by kstrtoint. >>> This will simplify code, since some error case not handled by >>> simple_strtol are handled by kstrtoint. >>> >>> Signed-off-by: LABBE Corentin >>> --- >>> drivers/atm/solos-pci.c | 28 +++++++++++++++------------- >>> 1 file changed, 15 insertions(+), 13 deletions(-) >>> >>> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c >>> index 3d7fb65..f944d75 100644 >>> --- a/drivers/atm/solos-pci.c >>> +++ b/drivers/atm/solos-pci.c >>> @@ -347,8 +347,8 @@ static char *next_string(struct sk_buff *skb) >>> */ >>> static int process_status(struct solos_card *card, int port, struct sk_buff *skb) >>> { >>> - char *str, *end, *state_str, *snr, *attn; >>> - int ver, rate_up, rate_down; >>> + char *str, *state_str, *snr, *attn; >>> + int ver, rate_up, rate_down, err; >>> >>> if (!card->atmdev[port]) >>> return -ENODEV; >>> @@ -357,11 +357,11 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb >>> if (!str) >>> return -EIO; >>> >>> - ver = simple_strtol(str, NULL, 10); >>> - if (ver < 1) { >>> + err = kstrtoint(str, 10, &ver); >>> + if (ver < 1 || err) { >> >> Is 'ver' initialized in case of error? If not, you have to check 'err' first. > > Hello > > Whatever if ver is initialized, I meant initialized by kstrtoint(). > since the conditional is an or, the test will always be true with the err value. I don't understand you. If you test 'ver' first, you risk testing uninitialized variable. > Anyway I will send an updated version. Let's see... > Regards MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/