Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760183AbbLCMVD (ORCPT ); Thu, 3 Dec 2015 07:21:03 -0500 Received: from foss.arm.com ([217.140.101.70]:48672 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755058AbbLCMVA (ORCPT ); Thu, 3 Dec 2015 07:21:00 -0500 Date: Thu, 3 Dec 2015 12:20:54 +0000 From: Catalin Marinas To: Yury Norov Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com, broonie@kernel.org, jan.dakinevich@gmail.com, ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, andrey.konovalov@linaro.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH v6 10/19] arm64:ilp32 use the native LP64 'start_thread' for ILP32 threads Message-ID: <20151203122054.GL10747@e104818-lin.cambridge.arm.com> References: <1447795019-30176-1-git-send-email-ynorov@caviumnetworks.com> <1447795019-30176-11-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447795019-30176-11-git-send-email-ynorov@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 39 On Wed, Nov 18, 2015 at 12:16:50AM +0300, Yury Norov wrote: > --- a/arch/arm64/include/asm/processor.h > +++ b/arch/arm64/include/asm/processor.h > @@ -28,6 +28,7 @@ > #ifdef __KERNEL__ > > #include > +#include > > #include > #include > @@ -123,6 +124,15 @@ static inline void start_thread(struct pt_regs *regs, unsigned long pc, > static inline void compat_start_thread(struct pt_regs *regs, unsigned long pc, > unsigned long sp) > { > +#ifdef CONFIG_ARM64_ILP32 > + /* ILP32 thread are started the same way as LP64 threads. > + Note we cannot use is_ilp32_compat_task here as that > + would introduce a header depency issue. */ > + if (test_thread_flag(TIF_32BIT_AARCH64)) { > + start_thread(regs, pc, sp); > + return; > + } Nitpicks: use IS_ENABLED(CONFIG_ARM64_ILP32) instead of #ifdef. Also follow the coding style for multi-line comments: /* * ..... * ..... */ -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/