Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760005AbbLCORg (ORCPT ); Thu, 3 Dec 2015 09:17:36 -0500 Received: from m50-134.163.com ([123.125.50.134]:45804 "EHLO m50-134.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbbLCORe (ORCPT ); Thu, 3 Dec 2015 09:17:34 -0500 From: Geliang Tang To: Johannes Weiner , Michal Hocko Cc: Geliang Tang , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/memcontrol.c: use list_{first,next}_entry Date: Thu, 3 Dec 2015 22:16:55 +0800 Message-Id: <9e62e3006561653fcbf0c49cf0b9c2b653a8ed0e.1449152124.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 X-CM-TRANSID: DtGowEBZsuXYTmBW7SbMAA--.2706S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF1DGw1Uuw48Ar1xCFWxZwb_yoWkZFX_Ca 97tw1UGw1UCrZ5C3Wjyw1fJFZFkFnY9FnFgF48tw1jyFyDKrs5tF1DC3y3KrW8Ww4rJ3sx C3s5Zw17Kr12vjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbz6wJUUUUU== X-Originating-IP: [116.77.146.26] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiGRrFmVXlPqH1YQAAsk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 49 To make the intention clearer, use list_{first,next}_entry instead of list_entry. Signed-off-by: Geliang Tang --- mm/memcontrol.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 79a29d5..a6301ea 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5395,16 +5395,12 @@ static void uncharge_list(struct list_head *page_list) unsigned long nr_file = 0; unsigned long nr_huge = 0; unsigned long pgpgout = 0; - struct list_head *next; struct page *page; - next = page_list->next; + page = list_first_entry(page_list, struct page, lru); do { unsigned int nr_pages = 1; - page = list_entry(next, struct page, lru); - next = page->lru.next; - VM_BUG_ON_PAGE(PageLRU(page), page); VM_BUG_ON_PAGE(page_count(page), page); @@ -5440,7 +5436,8 @@ static void uncharge_list(struct list_head *page_list) page->mem_cgroup = NULL; pgpgout++; - } while (next != page_list); + } while (!list_is_last(&page->lru, page_list) && + (page = list_next_entry(page, lru))); if (memcg) uncharge_batch(memcg, pgpgout, nr_anon, nr_file, -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/