Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758128AbbLCPGI (ORCPT ); Thu, 3 Dec 2015 10:06:08 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:28272 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757967AbbLCPGG (ORCPT ); Thu, 3 Dec 2015 10:06:06 -0500 X-IronPort-AV: E=Sophos;i="5.20,378,1444694400"; d="scan'208";a="322414409" Message-ID: <56605A5B.6000506@citrix.com> Date: Thu, 3 Dec 2015 15:06:03 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Vitaly Kuznetsov CC: , , Ingo Molnar , "H. Peter Anvin" , , Thomas Gleixner , "Boris Ostrovsky" Subject: Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs References: <1449139404-25101-1-git-send-email-david.vrabel@citrix.com> <87mvtr7p2s.fsf@vitty.brq.redhat.com> In-Reply-To: <87mvtr7p2s.fsf@vitty.brq.redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 24 On 03/12/15 11:23, Vitaly Kuznetsov wrote: > David Vrabel writes: > >> Adding the rtc platform device when there are no legacy irqs (no >> legacy PIC) > > No PIC != No legacy IRQs, Hyper-V Gen2 represents such a platform (and > it has RTC on irq8). I've tested this patch against it and it appears to > work because the device is present in ACPI and we initialize it in > drivers/acpi/acpi_cmos_rtc.c, add_rtc_cmos() bails out in the very > beginning as we see PNP0b00 device. It's not a legacy IRQ if it isn't going via the legacy PIC, it just happens to have the same number. I think it is safe to assume that any machine with a CMOS RTC but no PNP information is also going to have a legacy PIC. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/