Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760343AbbLCP73 (ORCPT ); Thu, 3 Dec 2015 10:59:29 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54531 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760226AbbLCP71 (ORCPT ); Thu, 3 Dec 2015 10:59:27 -0500 Date: Thu, 3 Dec 2015 16:59:24 +0100 From: Pavel Machek To: David Miller Cc: eric.dumazet@gmail.com, mhocko@kernel.org, akpm@osdl.org, linux-kernel@vger.kernel.org, jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org, rjw@rjwysocki.net, linux-mm@kvack.org, nic-devel@qualcomm.com, ronangeles@gmail.com, ebiederm@xmission.com Subject: Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation Message-ID: <20151203155923.GA31751@amd> References: <20151127082010.GA2500@dhcp22.suse.cz> <20151128145113.GB4135@amd> <1448906303.24696.133.camel@edumazet-glaptop2.roam.corp.google.com> <20151201.153628.148150792813486828.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151201.153628.148150792813486828.davem@davemloft.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2350 Lines: 54 On Tue 2015-12-01 15:36:28, David Miller wrote: > From: Eric Dumazet > Date: Mon, 30 Nov 2015 09:58:23 -0800 > > > On Sat, 2015-11-28 at 15:51 +0100, Pavel Machek wrote: > >> atl1c driver is doing order-4 allocation with GFP_ATOMIC > >> priority. That often breaks networking after resume. Switch to > >> GFP_KERNEL. Still not ideal, but should be significantly better. > >> > >> Signed-off-by: Pavel Machek > >> > >> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > >> index 2795d6d..afb71e0 100644 > >> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > >> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > >> @@ -1016,10 +1016,10 @@ static int atl1c_setup_ring_resources(struct atl1c_adapter *adapter) > >> sizeof(struct atl1c_recv_ret_status) * rx_desc_count + > >> 8 * 4; > >> > >> - ring_header->desc = pci_alloc_consistent(pdev, ring_header->size, > >> - &ring_header->dma); > >> + ring_header->desc = dma_alloc_coherent(&pdev->dev, ring_header->size, > >> + &ring_header->dma, GFP_KERNEL); > >> if (unlikely(!ring_header->desc)) { > >> - dev_err(&pdev->dev, "pci_alloc_consistend failed\n"); > >> + dev_err(&pdev->dev, "could not get memmory for DMA buffer\n"); > >> goto err_nomem; > >> } > >> memset(ring_header->desc, 0, ring_header->size); > >> > > > > It seems there is a missed opportunity to get rid of the memset() here, > > by adding __GFP_ZERO to the dma_alloc_coherent() GFP_KERNEL mask, > > or simply using dma_zalloc_coherent() > > Also, the Subject line needs to be adjusted. The proper format for > the Subject line is: > > [PATCH $TREE] $subsystem: $description. > > Where "$TREE" is either 'net' or 'net-next', $subsystem is the lowercase > name of the driver (here 'atl1c') and then a colon, and then a space, and > then the single-line description. Done, thanks. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/