Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760568AbbLCQYs (ORCPT ); Thu, 3 Dec 2015 11:24:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:41791 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbbLCQYr (ORCPT ); Thu, 3 Dec 2015 11:24:47 -0500 Date: Thu, 3 Dec 2015 17:24:45 +0100 From: Petr Mladek To: Torsten Duwe Cc: Steven Rostedt , Michael Ellerman , Jiri Kosina , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2) Message-ID: <20151203162445.GG8047@pathway.suse.cz> References: <20151125172608.9588569260@newverein.lst.de> <20151125172937.9425E69260@newverein.lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151125172937.9425E69260@newverein.lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 42 On Wed 2015-11-25 17:48:36, Torsten Duwe wrote: > * create the appropriate files+functions > arch/powerpc/include/asm/livepatch.h > klp_check_compiler_support, > klp_arch_set_pc > arch/powerpc/kernel/livepatch.c with a stub for > klp_write_module_reloc > This is architecture-independent work in progress. > * introduce a fixup in arch/powerpc/kernel/entry_64.S > for local calls that are becoming global due to live patching. > And of course do the main KLP thing: return to a maybe different > address, possibly altered by the live patching ftrace op. > > --- /dev/null > +++ b/arch/powerpc/include/asm/livepatch.h > @@ -0,0 +1,45 @@ [...] > +#include > +#include > + > +#ifdef CONFIG_LIVEPATCH > +static inline int klp_check_compiler_support(void) > +{ > +#if !defined(_CALL_ELF) || _CALL_ELF != 2 I am just curious why we do not check CC_USING_MPROFILE_KERNEL like in the other similar locations. It would look less cryptic. But I am not sure if it is precise enough. Best Regards, Petr > + return 1; > +#endif > + return 0; > +} > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/