Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbbLCQnF (ORCPT ); Thu, 3 Dec 2015 11:43:05 -0500 Received: from verein.lst.de ([213.95.11.211]:35625 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbbLCQnD (ORCPT ); Thu, 3 Dec 2015 11:43:03 -0500 Date: Thu, 3 Dec 2015 17:42:59 +0100 From: Christoph Hellwig To: Matias =?iso-8859-1?Q?Bj=F8rling?= Cc: Christoph Hellwig , Jens Axboe , Mark Brown , Keith Busch , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: linux-next: build failure after merge of the block tree Message-ID: <20151203164259.GA14678@lst.de> References: <20151202161936.22b23668cf9dea9872b5079b@kernel.org> <20151202164527.GA31048@lst.de> <565F5D96.5050902@kernel.dk> <565FFFA5.6000003@bjorling.me> <20151203090638.GA14329@lst.de> <566010EE.6050806@bjorling.me> <20151203095726.GA15428@lst.de> <566014BF.3080702@bjorling.me> <20151203102132.GA15905@lst.de> <5660226B.5070800@bjorling.me> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5660226B.5070800@bjorling.me> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 14 On Thu, Dec 03, 2015 at 12:07:23PM +0100, Matias Bj?rling wrote: > What is the reason to keep the nvme_ns internally to the nvme core? > > We can definitely move ->nsid and the lba_shift into nvm_dev. Only thing I > have is that it moves a small part of nvme logic into the lightnvm core. It's a structure specific to the NVM command set, and the block device use to implement it in Linux. Similar to how you wouldn't use the SCSI disk driver data structures to implement the tape driver for example. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/