Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752317AbbLCQnc (ORCPT ); Thu, 3 Dec 2015 11:43:32 -0500 Received: from foss.arm.com ([217.140.101.70]:50245 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbbLCQna (ORCPT ); Thu, 3 Dec 2015 11:43:30 -0500 Message-ID: <56607130.2010002@arm.com> Date: Thu, 03 Dec 2015 16:43:28 +0000 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Bjorn Helgaas CC: Thomas Gleixner , Jiang Liu , Phil Edworthy , linux-kernel@vger.kernel.org, Wolfram Sang Subject: Re: [PATCH] PCI: MSI: Only use the generic MSI layer when domain is hierarchical References: <1448288826-19058-1-git-send-email-marc.zyngier@arm.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 38 On 23/11/15 17:38, Thomas Gleixner wrote: > On Mon, 23 Nov 2015, Marc Zyngier wrote: > >> Since d8a1cb757550 ("PCI/MSI: Let pci_msi_get_domain use struct >> device::msi_domain"), we use the MSI domain associated to the PCI device. >> >> But finding a MSI domain doesn't mean that the domain is implemented >> using the generic MSI domain API, and a number of MSI controllers >> are still using the arch_setup_msi_irq/arch_teardown_msi_irqs. >> >> In order to avoid a firework on these systems, check that the domain >> we just obtained is hierarchical. If not, don't use the generic MSI >> stuff and stick with the old one. Not pretty, but reliable. >> >> Another insentive to rework those drivers and phase out this API. >> >> Reported-by: Phil Edworthy >> Tested-by: Phil Edworthy >> Signed-off-by: Marc Zyngier > > Acked-by: Thomas Gleixner > Hi Bjorn, Do you have any objection to taking this patch? It fixes a real issue for drivers not using the generic MSI domains. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/