Date: Thu, 3 Dec 2015 16:56:07 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: David Airlie <airlied@linux.ie>, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>, Jon Medhurst <tixy@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Rob Herring <robh@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Arnd Bergmann <arnd@arndb.de>,
        Olof Johansson <olof@lixom.net>, Punit Agrawal <punit.agrawal@arm.com>,
        DRI devel <dri-devel@lists.freedesktop.org>,
        devicetree <devicetree@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LAKML <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/4] drm: Add support for the ARM HDLCD display
 controller
Message-ID: <20151203165606.GS8644@n2100.arm.linux.org.uk>
References: <1449139249-9171-1-git-send-email-Liviu.Dudau@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449139249-9171-1-git-send-email-Liviu.Dudau@arm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1529
Lines: 35

On Thu, Dec 03, 2015 at 10:40:45AM +0000, Liviu Dudau wrote:
> This series depends on Sudeep Holla's SCPI driver (now in mainline) and on
> the tda998x patches that have been queued on Russell's patch system here [1].

Now merged into my tree.

Can I ask a fairly obvious question...

>  drivers/gpu/drm/Kconfig                            |   2 +
>  drivers/gpu/drm/Makefile                           |   1 +
>  drivers/gpu/drm/arm/Kconfig                        |  29 ++
>  drivers/gpu/drm/arm/Makefile                       |   2 +
>  drivers/gpu/drm/arm/hdlcd_crtc.c                   | 327 ++++++++++++
>  drivers/gpu/drm/arm/hdlcd_drv.c                    | 555 +++++++++++++++++++++
>  drivers/gpu/drm/arm/hdlcd_drv.h                    |  42 ++
>  drivers/gpu/drm/arm/hdlcd_regs.h                   |  87 ++++

Why is the subdirectory called "arm" and not "hdlcd" ?

ARM Ltd have more than one display controller (they have the AMBA PL110
and PL111 in addition to this), and (afaics) this doesn't drive these.
HDLCD probably won't be the last display hardware which ARM Ltd comes
out with either.

So, I think naming the subdirectory after the vendor is probably a
mistake.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/