Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753019AbbLCQ7E (ORCPT ); Thu, 3 Dec 2015 11:59:04 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:51864 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbbLCQ7B (ORCPT ); Thu, 3 Dec 2015 11:59:01 -0500 Date: Thu, 3 Dec 2015 11:58:50 -0500 From: Sowmini Varadhan To: "Bowers, AndrewX" Cc: Andy Shevchenko , David Miller , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , netdev Subject: Re: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM Message-ID: <20151203165850.GB15262@oracle.com> References: <20151105.103126.148818796422971143.davem@davemloft.net> <20151105.110506.1901401372160830603.davem@davemloft.net> <20151105.133131.1900833527415923596.davem@davemloft.net> <26D9FDECA4FBDD4AADA65D8E2FC68A4A0F96CBB6@ORSMSX104.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26D9FDECA4FBDD4AADA65D8E2FC68A4A0F96CBB6@ORSMSX104.amr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 33 On (12/03/15 16:53), Bowers, AndrewX wrote: > > I get an error -11 on driver init with this patch applied, I can > revert it and everything works normally. Dmesg screenshot is attached, > can supply complete dmesg log if needed. Yes, that's the same thing that I'm running into as well. Using this patch makes this work. But this adds some ugly ifdef's, and other methods should be explored. --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -9102,9 +9102,11 @@ struct i40e_vsi *i40e_vsi_setup(struct i40e_pf *pf, u8 ty ret = i40e_config_netdev(vsi); if (ret) goto err_netdev; +#if defined(CONFIG_SPARC) || defined(CONFIG_OF) ret = i40e_macaddr_init(vsi, pf->hw.mac.addr); if (ret) goto err_netdev; +#endif ret = register_netdev(vsi->netdev); if (ret) goto err_netdev; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/