Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbbLCRAw (ORCPT ); Thu, 3 Dec 2015 12:00:52 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:46656 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbbLCRAs (ORCPT ); Thu, 3 Dec 2015 12:00:48 -0500 Date: Thu, 3 Dec 2015 10:00:41 -0700 From: Jason Gunthorpe To: "Wilck, Martin" Cc: Jarkko Sakkinen , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Uwe Kleine-K??nig Subject: Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Message-ID: <20151203170041.GA32175@obsidianresearch.com> References: <1448996309-15220-1-git-send-email-jgunthorpe@obsidianresearch.com> <20151201213351.GC5071@intel.com> <20151202182726.GB30972@obsidianresearch.com> <20151202191155.GA2832@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1402 Lines: 31 On Thu, Dec 03, 2015 at 09:30:30AM +0100, Wilck, Martin wrote: > On Mi, 2015-12-02 at 12:11 -0700, Jason Gunthorpe wrote: > > > > What is the address tpm_tis should be using? I see two things, it > > > either uses the x86 default address or it expects the ACPI to have a > > > MEM resource. AFAIK ACPI should never rely on hard wired addresses, so > > > I removed that code in this series. Perhaps tpm_tis should be using > > > control_area_pa ? Will ACPI ever present a struct resource? (if yes, > > > why isn't tpm_crb using one?) > > > > Is then still a problem. On Martin's system the MSFT0101 device does > > not have a struct resource attached to it. Does any system, or is this > > just dead code? > > ACPI defines a mem resource corresponding to the standard TIS memory > area on my system, and it used to be detected fine with Jarkko's patch. > Somehow your latest changes broke it, not sure why. Are you certain? Based on what you sent me, that output is only possible if there is no mem resource. With the prior arrangement no mem resource means the x86 default address is used, which is the only way I can see how your system works. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/