Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbbLCRCV (ORCPT ); Thu, 3 Dec 2015 12:02:21 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:58002 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbbLCRCT (ORCPT ); Thu, 3 Dec 2015 12:02:19 -0500 Date: Thu, 3 Dec 2015 10:02:17 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm_crb: Use the common ACPI definition of struct acpi_tpm2 Message-ID: <20151203170217.GB32175@obsidianresearch.com> References: <20151202191900.GA12489@obsidianresearch.com> <20151203082753.GA18043@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151203082753.GA18043@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 24 On Thu, Dec 03, 2015 at 10:27:53AM +0200, Jarkko Sakkinen wrote: > On Wed, Dec 02, 2015 at 12:19:00PM -0700, Jason Gunthorpe wrote: > > include/acpi/actbl2.h is the proper place for these definitions > > and the needed TPM2 ones have been there since > > commit 413d4a6defe0 ("ACPICA: Update TPM2 ACPI table") > > > > This also drops the le32_to_cpu for members of this table, > > consistent with other ACPI stuff. > > Why le32_to_cpu() is not needed? Why is it needed? None of the fields are marked le32 in the struct and no other ACPI thing I could find swaps. If swapping is needed then the struct fields must be declared as 'le' Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/