Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbbLCTBL (ORCPT ); Thu, 3 Dec 2015 14:01:11 -0500 Received: from mail-ig0-f169.google.com ([209.85.213.169]:35983 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbbLCTBJ (ORCPT ); Thu, 3 Dec 2015 14:01:09 -0500 MIME-Version: 1.0 In-Reply-To: <20151203184051.GE3213@pd.tnic> References: <1448404418-28800-1-git-send-email-toshi.kani@hpe.com> <1448404418-28800-2-git-send-email-toshi.kani@hpe.com> <20151201135000.GB4341@pd.tnic> <20151201171322.GD4341@pd.tnic> <1449168859.9855.54.camel@hpe.com> <20151203184051.GE3213@pd.tnic> Date: Thu, 3 Dec 2015 11:01:08 -0800 X-Google-Sender-Auth: 5UNekrgf-C0kljKyqX5hd0PlnGw Message-ID: Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() From: Linus Torvalds To: Borislav Petkov Cc: Toshi Kani , Dan Williams , Andrew Morton , "Rafael J. Wysocki" , Tony Luck , Vishal L Verma , Linux MM , "linux-nvdimm@lists.01.org" , Linux ACPI , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 36 On Thu, Dec 3, 2015 at 10:40 AM, Borislav Petkov wrote: > On Thu, Dec 03, 2015 at 11:54:19AM -0700, Toshi Kani wrote: >> Adding a new type for regular memory will require inspecting the codes >> using IORESOURCE_MEM currently, and modify them to use the new type if >> their target ranges are regular memory. There are many references to this >> type across multiple architectures and drivers, which make this inspection >> and testing challenging. > > What's wrong with adding a new type_flags to struct resource and not > touching IORESOURCE_* at all? Bah. Both of these ideas are bogus. Just add a new flag. The bits are already modifiers that you can *combine* to show what kind of resource it is, and we already have things like IORESOURCE_PREFETCH etc, that are in *addition* to the normal IORESOURCE_MEM bit. Just add another modifier: IORESOURCE_RAM. So it would still show up as IORESOURCE_MEM, but it would have additional information specifying that it's actually RAM. If somebody does something like if (res->flags == IORESOURCE_MEM) then they are already completely broken and won't work *anyway*. It's a bitmask, bit a set of values. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/