Date: Thu, 3 Dec 2015 14:06:14 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: "Shi, Yang" <yang.shi@linaro.org>
Cc: Dave Hansen <dave.hansen@intel.com>, akpm@linux-foundation.org,
        mingo@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linaro-kernel@lists.linaro.org
Subject: Re: [PATCH V2 2/7] mm/gup: add gup trace points
Message-ID: <20151203140614.75f49aad@gandalf.local.home>
In-Reply-To: <56608BA2.2050300@linaro.org>
References: <1449096813-22436-1-git-send-email-yang.shi@linaro.org>
	<1449096813-22436-3-git-send-email-yang.shi@linaro.org>
	<565F8092.7000001@intel.com>
	<20151202231348.7058d6e2@grimm.local.home>
	<56608BA2.2050300@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1239
Lines: 43

On Thu, 03 Dec 2015 10:36:18 -0800
"Shi, Yang" <yang.shi@linaro.org> wrote:

> > called directly that calls these functions internally and the tracepoint
> > can trap the return value.  
> 
> This will incur more changes in other subsystems (futex, kvm, etc), I'm 
> not sure if it is worth making such changes to get return value.

No, it wouldn't require any changes outside of this.

-long __get_user_pages(..)
+static long __get_user_pages_internal(..)
{
  [..]
}
+
+long __get_user_pages(..)
+{
+	long ret;
+	ret = __get_user_pages_internal(..);
+	trace_get_user_pages(.., ret)
+}

> 
> > I can probably make function_graph tracer give return values, although
> > it will give a return value for void functions as well. And it may give
> > long long returns for int returns that may have bogus data in the
> > higher bits.  
> 
> If the return value requirement is not limited to gup, the approach 
> sounds more reasonable.
>

Others have asked about it. Maybe I should do it.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/