Date: Thu, 3 Dec 2015 14:54:01 -0500
From: Mike Snitzer <snitzer@redhat.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>, Mandeep Baines <msb@chromium.org>,
        Will Drewry <wad@chromium.org>, Alasdair Kergon <agk@redhat.com>,
        dm-devel@redhat.com, linux-kernel@vger.kernel.org,
        Kees Cook <keescook@chromium.org>, Mark Salyzyn <salyzyn@google.com>
Subject: Re: [PATCH v2 0/2] dm verity: add support for error correction
Message-ID: <20151203195401.GA5444@redhat.com>
References: <1446688954-29589-1-git-send-email-samitolvanen@google.com>
 <1449152791-33586-1-git-send-email-samitolvanen@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449152791-33586-1-git-send-email-samitolvanen@google.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1710
Lines: 40

On Thu, Dec 03 2015 at  9:26am -0500,
Sami Tolvanen <samitolvanen@google.com> wrote:

> Changes since v1:
> 
>   - Added CONFIG_DM_VERITY_FEC and split error correction into
>     dm-verity-fec.[ch] to further separate the functionality from the
>     rest of dm-verity. Follows the same pattern as dm-uevent.
> 
>   - Added missing dependencies for REED_SOLOMON to Kconfig.
> 
>   - Renamed dm-verity.c to dm-verity-target.c to allow an optional
>     object to be added. Follows the naming convention of dm-cache and
>     dm-era.
> 
>   - Changed the algorithm to work with one or more small buffers (~4k)
>     instead of a single large one. The more buffers we can allocate,
>     the faster it will work, but we don't have to preallocate a large
>     amount of memory anymore.
> 
>   - Changed memory allocation to use mempools. v2 preallocates all the
>     memory required for each worker thread to guarantee forward
>     progress in case of memory pressure. The code attempts to allocate
>     more buffers (using GFP_NOIO) and uses them if available.
> 
>   - Added graceful handling of IO errors, which are now treated as any
>     other corruption.
> 
>   - Rebased against linux-dm/for-next.

Thanks a lot for these advances, at a high-level it sounds like you've
handled the issues raised as part of v1 review very well.

I'll review closer now.  Goal is to get these changes staged in
linux-next for upstream inclusion during the 4.5 merge window.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/