Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898AbbLCU1U (ORCPT ); Thu, 3 Dec 2015 15:27:20 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:45727 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531AbbLCU1S (ORCPT ); Thu, 3 Dec 2015 15:27:18 -0500 Date: Thu, 03 Dec 2015 15:27:17 -0500 (EST) Message-Id: <20151203.152717.1108068845756443724.davem@davemloft.net> To: sboyd@codeaurora.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, peppe.cavallaro@st.com, netdev@vger.kernel.org, manabian@gmail.com Subject: Re: [PATCH] stmmac: ipq806x: Return error values instead of pointers From: David Miller In-Reply-To: <1449129315-1427-1-git-send-email-sboyd@codeaurora.org> References: <1449129315-1427-1-git-send-email-sboyd@codeaurora.org> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 03 Dec 2015 12:27:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 17 From: Stephen Boyd Date: Wed, 2 Dec 2015 23:55:15 -0800 > Typically we return error pointers when we want to use those > pointers in the non-error case, but this function is just > returning error pointers or NULL for success. Change the style to > plain int to follow normal kernel coding styles. > > Cc: Joachim Eastwood > Signed-off-by: Stephen Boyd Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/