Message-ID: <5660BDC2.5060400@linaro.org>
Date: Thu, 03 Dec 2015 14:10:10 -0800
From: "Shi, Yang" <yang.shi@linaro.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>
CC: Dave Hansen <dave.hansen@intel.com>, akpm@linux-foundation.org,
        mingo@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linaro-kernel@lists.linaro.org
Subject: Re: [PATCH V2 2/7] mm/gup: add gup trace points
References: <1449096813-22436-1-git-send-email-yang.shi@linaro.org>	<1449096813-22436-3-git-send-email-yang.shi@linaro.org>	<565F8092.7000001@intel.com>	<20151202231348.7058d6e2@grimm.local.home>	<56608BA2.2050300@linaro.org> <20151203140614.75f49aad@gandalf.local.home>
In-Reply-To: <20151203140614.75f49aad@gandalf.local.home>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1582
Lines: 56

On 12/3/2015 11:06 AM, Steven Rostedt wrote:
> On Thu, 03 Dec 2015 10:36:18 -0800
> "Shi, Yang" <yang.shi@linaro.org> wrote:
>
>>> called directly that calls these functions internally and the tracepoint
>>> can trap the return value.
>>
>> This will incur more changes in other subsystems (futex, kvm, etc), I'm
>> not sure if it is worth making such changes to get return value.
>
> No, it wouldn't require any changes outside of this.
>
> -long __get_user_pages(..)
> +static long __get_user_pages_internal(..)
> {
>    [..]
> }
> +
> +long __get_user_pages(..)
> +{
> +	long ret;
> +	ret = __get_user_pages_internal(..);
> +	trace_get_user_pages(.., ret)
> +}

Thanks for this. I just checked the fast version, it looks it just has 
single return path, so this should be just needed by slow version.

>
>>
>>> I can probably make function_graph tracer give return values, although
>>> it will give a return value for void functions as well. And it may give
>>> long long returns for int returns that may have bogus data in the
>>> higher bits.
>>
>> If the return value requirement is not limited to gup, the approach
>> sounds more reasonable.
>>
>
> Others have asked about it. Maybe I should do it.

If you are going to add return value in common trace code, I won't do 
the gup specific one in V3.

Thanks,
Yang

>
> -- Steve
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/