Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbbLCW5F (ORCPT ); Thu, 3 Dec 2015 17:57:05 -0500 Received: from mga14.intel.com ([192.55.52.115]:63140 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167AbbLCW5D (ORCPT ); Thu, 3 Dec 2015 17:57:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,378,1444719600"; d="scan'208";a="866219621" Date: Thu, 3 Dec 2015 14:43:09 -0800 From: Yunhong Jiang To: Thomas Gleixner Cc: okuno.kohji@jp.panasonic.com, linux-kernel@vger.kernel.org Subject: Re: Can we conditionally force threading irq with primary and thread handler? Message-ID: <20151203224309.GB19650@jnakajim-build> References: <20151203191125.GA8945@jnakajim-build> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 37 On Thu, Dec 03, 2015 at 11:33:14PM +0100, Thomas Gleixner wrote: > Yunhong, > > On Thu, 3 Dec 2015, Yunhong Jiang wrote: > > > Hi, Thomas > > On Commit 2a1d3ab8986d1b2 ("genirq: Handle force threading of irqs > > with primary and thread handler"), even if the caller of > > request_threaded_irq() provides a primary handler, that primary handler will > > be invoked in thread context. This may cause some latency issue for high > > real time requirement. > > > > I checked the discussion on https://lkml.org/lkml/2015/9/19/372 with > > Okuno and seems we need this change only if the irq is shared, otherwise, we > > can still use Okuno's mechanism, am I right? Do you think it's ok to force > > the primary handler for shared IRQ, otherwise, clear the IRQF_ONESHOT? > > If you want to avoid that the primary handler is force threaded, then > you can indicate that with IRQF_NO_THREAD. Thaks for reply. Sure, will do that way. Just feel a bit weird with a valid thread_fn and a IRQF_NO_THREAD flags. Thanks --jyh > > Thanks, > > tglx > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/