Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754580AbbLDANW (ORCPT ); Thu, 3 Dec 2015 19:13:22 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:35463 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754308AbbLDAMa (ORCPT ); Thu, 3 Dec 2015 19:12:30 -0500 MIME-Version: 1.0 In-Reply-To: <1449183781-2163-1-git-send-email-linux@rainbow-software.org> References: <20151118083455.331768508@telegraphics.com.au> <1449183781-2163-1-git-send-email-linux@rainbow-software.org> From: Julian Calaby Date: Fri, 4 Dec 2015 11:12:10 +1100 Message-ID: Subject: Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips To: Ondrej Zary Cc: Finn Thain , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2031 Lines: 55 Hi Finn, Ondrej, One small question: On Fri, Dec 4, 2015 at 10:03 AM, Ondrej Zary wrote: > Add I/O register mapping for DTC chips and enable PDMA mode. > > These chips have 16-bit wide HOST BUFFER register (counter register at > offset 0x0d increments by 2 on each HOST BUFFER read). > > Large PIO transfers crash at least the DTCT-436P chip (all reads result > in 0xFF) so this patch actually makes it work. > > The chip also crashes when we bang the C400 host status register too > heavily after PDMA write - a small udelay is needed. > > Signed-off-by: Ondrej Zary > --- > # hdparm -t --direct /dev/sdb > > /dev/sdb: > Timing O_DIRECT disk reads: 4 MB in 3.78 seconds = 1.06 MB/sec > > > drivers/scsi/NCR5380.h | 1 + > drivers/scsi/g_NCR5380.c | 47 +++++++++++++++++++++++----------------------- > 2 files changed, 25 insertions(+), 23 deletions(-) > > diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c > index fae4332..04f6c29 100644 > --- a/drivers/scsi/g_NCR5380.c > +++ b/drivers/scsi/g_NCR5380.c > @@ -415,7 +415,8 @@ static int __init generic_NCR5380_detect(struct scsi_host_template *tpnt) > hostdata->c400_blk_cnt = 1; > hostdata->c400_host_buf = 4; > } > - if (overrides[current_override].board == BOARD_NCR53C400A) { > + if (overrides[current_override].board == BOARD_NCR53C400A || > + overrides[current_override].board == BOARD_DTC3181E) { These if statements are starting to get a bit long, would it make sense to replace them with a flag or equivalent? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/