Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754459AbbLDAMk (ORCPT ); Thu, 3 Dec 2015 19:12:40 -0500 Received: from tex.lwn.net ([70.33.254.29]:42441 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754406AbbLDAMj (ORCPT ); Thu, 3 Dec 2015 19:12:39 -0500 Date: Thu, 3 Dec 2015 17:12:37 -0700 From: Jonathan Corbet To: Scotty Bauer Cc: linux-kernel@vger.kernel.org Subject: Re: Accessing user-land memory without safe functions Message-ID: <20151203171237.73877893@lwn.net> In-Reply-To: <5660AC06.8080300@eng.utah.edu> References: <5660AC06.8080300@eng.utah.edu> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 24 On Thu, 3 Dec 2015 13:54:30 -0700 Scotty Bauer wrote: > Since I've seen this a couple times now I'm wondering if my > understanding of touching user-land memory is flawed. > > For the above example Ioctl, the proper way to get access to those fields > through the safe copy_from_user or get_user() functions, correct? > > I'm wondering if I should submit patches to fix the issues I've found, > but now I'm doubting whether they're really issues at all. They sound like bugs to me, though it would be easier to say for sure with a pointer to a specific function in the kernel source. Please point something out, or, perhaps better, send a patch fixing one of them. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/