Subject: Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
References: <1449110668-23647-1-git-send-email-xuejiancheng@huawei.com>
 <1728470.0OiiXMcl88@wuerfel>
CC: <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <linux@arm.linux.org.uk>, <khilman@linaro.org>, <olof@lixom.net>,
        <xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
        <zhangfei.gao@linaro.org>, <bintian.wang@huawei.com>,
        <suwenping@hisilicon.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <yanhaifeng@hisilicon.com>,
        <gaofei@hisilicon.com>, <ml.yang@hisilicon.com>,
        <yanghongwei@hisilicon.com>
From: xuejiancheng <xuejiancheng@huawei.com>
Message-ID: <5660FA2E.6040601@huawei.com>
Date: Fri, 4 Dec 2015 10:27:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1728470.0OiiXMcl88@wuerfel>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2628
Lines: 113

Hi Arnd,
   Thank you very much for all your comments.

On 2015/12/3 17:36, Arnd Bergmann wrote:
> On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote:
> 
>> +
>> +/dts-v1/;
>> +#include "hi3519.dtsi"
>> +
>> +/ {
>> +	model = "HiSilicon HI3519 DEMO Board";
>> +	compatible = "hisilicon,hi3519";
>> +
>> +	chosen {
>> +		bootargs = "mem=64M console=ttyAMA0,115200 early_printk \
>> +root=/dev/mtdblock2 rootfstype=jffs2 \
>> +mtdparts=hi_sfc:1M(boot),4M(kernel),11M(rootfs)";
>> +	};
> 
> Most of the arguments should be dropped and replaced with the respective
> DT properties in this file:
> 
> mem:		/memory (you have that already, but the size seems wrong)
> console:	/chosen/stdout-path
> early_printk:	just drop this, maybe use "earlycon")
> root:		this one is fine
> rootfstype:	should not be needed
> mtdparts:	use nodes below the MTD device
> 

This chosen node is just for debug. The real parameters will be set at boot stage.
I will drop it.

>> +
>> +#include "skeleton.dtsi"
>> +#include <dt-bindings/clock/hi3519-clock.h>
>> +/ {
>> +	aliases {
>> +		serial0 = &uart0;
>> +	};
> 
> Move this into the .dts file.

OK. Thank you.

> 
>> +
>> +			uart0: uart@12100000 {
> 
> rename to serial@12100000

OK.

> 
>> +			dual_timer1: dual_timer@12001000 {
>> +				compatible = "arm,sp804", "arm,primecell";
>> +				interrupts = <0 66 4>, <0 67 4>;
>> +				reg = <0x12001000 0x1000>;
>> +				clocks = <&crg HI3519_FIXED_3M>;
>> +				status = "disable";
>> +			};
> 
> rename to timer@12001000

OK.

> 
>> +		sysctrl: system-controller@12020000 {
>> +			compatible = "hisilicon,sysctrl";
>> +			reg = <0x12020000 0x1000>;
>> +			reboot-offset = <0x4>;
>> +		};
> 
> Is this one identical to the one in hip04?
> 
> If not, pick a new unique compatible string

Yes. It's compatible with the one in hip04.

> 
>> +
>> +		crg: crg@12010000 {
>> +			compatible = "hisilicon,hi3519-crg";
> 
> 
> what is a "crg"? Is there a standard name for these?

The "crg" means Clock and Reset Generator. It's a block which supplies clock
and reset signals for other modules in the chip. I used "hi3519-clock"
in last version patch. Rob Herring suggested that it's better to use "hi3519-crg"
as the compatible string if it's a whole block.

what about writing like this？

crg: clock-reset-controller@12010000 {
	compatible = "hisilicon,hi3519-crg";
	}

> 
> 	Arnd
> 
> .
> 

Jiancheng
.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/